Offer a second way to stop a run in the window, and the dependents in the way on the plan - #37
Merged
Merged
Conversation
… the way on the plan The window had one level of stopping a run while the terminal has two, and since the step limit counts time without progress, a service that reports progress forever kept the window running until it was ended from the task manager. - Interrupt goes grey once pressed and the sheet says the run was interrupted. If the run is still going three seconds later, "Leave the rest undone" appears to the left of Interrupt: it stops watching the step in flight and puts nothing back, like a second Ctrl+C. The rule lives in a view model of its own (Underway), and the window cancels the second token only when it agrees, so a double press never reaches it. - Closing the window during a run asks the first level through the same door and says the window closes when the run has ended. - A run that was interrupted says so when it ends, read off the skipped steps, and says when nothing was put back. - A stop or restart with running dependents, and a force stop refused for them, offer "Also stop the N in the way". It builds the plan on the sheet again with them stopped first, as --dependents does, from the plan's own names rather than the picked rows. A start type change that stops offers nothing, because start-type refuses --dependents. A restart as administrator carries the choice (hand-over format 2). - Warnings and refusals share one line type and one template (PlanSentence). - The progress line moved under the buttons at the foot of the plan. - README no longer says the window always takes dependents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for a person
--dependentsdoes. Nothing runs until the button at the foot is pressed, and a restart as administrator keeps the choice.How it is built
Underway(new view model) holds the run as it goes: the progress line moved there fromPlanned, plus the two levels. The rule guarding the second level (only after the first, only after three seconds of the run still going) lives there, and the window cancels the second token only when it agrees.PlanSentencereplacesPlanWarningLine: one line type and one template for warnings and refusals, each line carrying its own offer, button name and tooltip.TakeTheOfferrebuilds from the plan on the sheet, not from the picked rows. A forcing sheet opened from a failure is about the entry that failed.Depsfield, accepted only beside stop, restart and the two forcing kinds.Checked
🤖 Generated with Claude Code