Skip to content

Offer a second way to stop a run in the window, and the dependents in the way on the plan - #37

Merged
donislawdev merged 1 commit into
mainfrom
fix/stability-package-gui
Sep 30, 2026
Merged

donislawdev merged 1 commit into
mainfrom
fix/stability-package-gui

Conversation

@donislawdev

Copy link
Copy Markdown
Owner

What changes for a person

  • A second way to stop a run in the window. Interrupt goes grey once pressed and the plan says the run was interrupted. If the run is still going three seconds later, "Leave the rest undone" appears to the left of Interrupt. It stops watching the step in flight and puts nothing back, the way a second Ctrl+C does in a terminal. It exists for a service that reports progress forever, which used to leave a window that could only be ended from the task manager.
  • Closing the window during a run asks the first level and says the window closes when the run has ended.
  • An interrupted run says so when it ends, and says when nothing was put back.
  • "Also stop the N in the way" under a stop or restart with running dependents, and under a force stop refused for them. It builds the same plan again with them stopped first, as --dependents does. Nothing runs until the button at the foot is pressed, and a restart as administrator keeps the choice.

How it is built

  • Underway (new view model) holds the run as it goes: the progress line moved there from Planned, plus the two levels. The rule guarding the second level (only after the first, only after three seconds of the run still going) lives there, and the window cancels the second token only when it agrees.
  • PlanSentence replaces PlanWarningLine: one line type and one template for warnings and refusals, each line carrying its own offer, button name and tooltip.
  • TakeTheOffer rebuilds from the plan on the sheet, not from the picked rows. A forcing sheet opened from a failure is about the entry that failed.
  • Hand-over format 2 with a Deps field, accepted only beside stop, restart and the two forcing kinds.
  • The component catalogue shows the foot of the plan during a run for the first time.

Checked

  • Window tests of the classes this touches: 228 of 228. Architecture: 182 of 182.
  • Mutation register: 18 new entries, 13 re-anchored, neighbours - 48 of 48 caught.
  • Not checked: the window on a live machine with a run that never ends, the keyboard after Interrupt greys (the test host has no keyboard focus), the full gate.

🤖 Generated with Claude Code

… the way on the plan

The window had one level of stopping a run while the terminal has two, and since
the step limit counts time without progress, a service that reports progress
forever kept the window running until it was ended from the task manager.

- Interrupt goes grey once pressed and the sheet says the run was interrupted.
  If the run is still going three seconds later, "Leave the rest undone"
  appears to the left of Interrupt: it stops watching the step in flight and
  puts nothing back, like a second Ctrl+C. The rule lives in a view model of
  its own (Underway), and the window cancels the second token only when it
  agrees, so a double press never reaches it.
- Closing the window during a run asks the first level through the same door
  and says the window closes when the run has ended.
- A run that was interrupted says so when it ends, read off the skipped steps,
  and says when nothing was put back.
- A stop or restart with running dependents, and a force stop refused for
  them, offer "Also stop the N in the way". It builds the plan on the sheet
  again with them stopped first, as --dependents does, from the plan's own
  names rather than the picked rows. A start type change that stops offers
  nothing, because start-type refuses --dependents. A restart as
  administrator carries the choice (hand-over format 2).
- Warnings and refusals share one line type and one template (PlanSentence).
- The progress line moved under the buttons at the foot of the plan.
- README no longer says the window always takes dependents.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8372959e-f936-43c2-b8cd-13506e9d6818


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@donislawdev
donislawdev merged commit 35f81e7 into main Sep 30, 2026
8 checks passed
@donislawdev
donislawdev deleted the fix/stability-package-gui branch September 30, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant