Say when Windows starts an ended service again, before and after the run - #38
Merged
Merged
Conversation
The recovery list is now read with the delay of every item. The warning that
ending a process makes Windows start a service again names the delays beside
each entry ("Spooler (5 s later)", "W32Time (60 s or 120 s later)"), every
different one, because which item runs depends on a failure count Windows does
not hand out.
After a run that ended a process, the report says who comes back and when: the
terminal in a paragraph under the steps, the window as a second sentence of the
notice. An entry that reported Stopped before the ending, one Windows started
again at once and one the run started again itself are left out. The rule is
Microsoft's own - a service fails when its process ends without reporting
Stopped - so a neighbour still in StopPending when the process went is named.
No field is added to the JSON - the delays reach it only inside the message.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
IEndingFactsReader.ReadRecoveryreturnsRecoveryItem(kind and delay) instead of bare kinds.recoveryRestartswarning says when, beside every entry:Spooler (5 s later),W32Time (60 s or 120 s later). Every different delay in the list, in list order, because which item runs depends on a failure count Windows does not hand out (SERVICE_FAILURE_ACTIONSWon learn.microsoft.com). Carried onPlanWarning.Restarts, empty for every other kind.PlanRun.ComingBack): the terminal in a paragraph under the steps, the window as a second sentence of the notice. Left out: an entry that reported Stopped before the ending, the entry Windows started again at once (its own line says so), and anything the run started again itself. A neighbour still inStopPendingwhen the process went is named - it never reported Stopped, so by the documented rule it fails with the process.--jsononly inside the warning'smessage.Checked
RecoveryContractTestsnow holds the delays againstsc.exe qfailure RpcSs.bws kill Spooler --dry-runon a real machine:Spooler (5 s later), matchingsc.exe qfailure Spooler(5000 ms twice).WpnServiceshows its five delays,W32Timeits two.Not checked
🤖 Generated with Claude Code