site: a page for every preset, made from the registry, in both languages - #149
Conversation
/presets/ and /pl/presety/ list the six presets, and each preset gets a page of its own: the question, what it usually catches, what the set holds at its defaults (files, targets, bytes, formats), how many files the system under test should accept, reject or decide on, every setting with what it takes and its default, and the commands to run it. The home page and the documentation link to them, and Presets is in the header. Nothing on those pages is typed. The settings come from the registry, the budget from tfg preset show and the reactions from a dry run of the set, asked in process by the guard. The pages themselves are made from the registry after the language text is filled in, so a seventh preset gets its pages without anybody adding them, and without its Polish words the render stops and names it. The English words of a preset are copies of the registry and are now held to it - the questions had been copies with nothing comparing them. The Polish page has to carry as many catches as the English one, because a page one sentence short renders without complaint. A text setting is described by its shape rather than the word "text", on the formats page as well, where two archive settings said nothing about the value they want. The sitemap guard counts the pages that were rendered rather than the ones the language files list, and asserts it reached the made pages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (29)
📒 Files selected for processing (20)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (16)
🧰 Additional context used📓 Path-based instructions (11)Applies to text shown to the user (labels, buttons, tooltips, placeholders, dialogs, errors, status messages, empty states, translations).⚙️ CodeRabbit configuration file Files:
Verify tests check real behavior and would fail if the implementation were broken.⚙️ CodeRabbit configuration file Files:
These are end-user desktop applications.⚙️ CodeRabbit configuration file Files:
Performance is a known weak spot of these projects.⚙️ CodeRabbit configuration file Files:
Applies only to code that builds or styles a GUI.⚙️ CodeRabbit configuration file Files:
Domain: test file generator (Go; `tfg` CLI and `tfg-gui` Fyne window over one engine).⚙️ CodeRabbit configuration file Files:
SECURITY, HIGH PRIORITY.⚙️ CodeRabbit configuration file Files:
These apps are QA/developer tools.⚙️ CodeRabbit configuration file Files:
Source of the public project website (generated output is excluded from review).⚙️ CodeRabbit configuration file Files:
Go code.⚙️ CodeRabbit configuration file Files:
All code in this repository is written by an AI coding agent (Claude Code).⚙️ CodeRabbit configuration file Files:
🪛 HTMLHint (1.9.2)web/templates/layout.html[error] 54-54: Special characters must be escaped : [ < ]. (spec-char-escape) [error] 54-54: Special characters must be escaped : [ > ]. (spec-char-escape) [error] 54-54: Tag must be paired, no start tag: [ ] (tag-pair) web/templates/social.html[error] 233-233: Special characters must be escaped : [ < ]. (spec-char-escape) [error] 233-233: Special characters must be escaped : [ > ]. (spec-char-escape) [error] 233-233: Tag must be paired, no start tag: [ ] (tag-pair) web/content/pl/presets.html[error] 1-1: Doctype must be declared before any non-comment content. (doctype-first) web/content/en/preset.html[error] 1-1: Doctype must be declared before any non-comment content. (doctype-first) web/content/en/presets.html[error] 1-1: Doctype must be declared before any non-comment content. (doctype-first) web/content/pl/preset.html[error] 1-1: Doctype must be declared before any non-comment content. (doctype-first) 📝 WalkthroughWalkthroughThe site adds localized preset overview and detail pages. It populates them with registered preset settings, budgets, and outcomes, and updates navigation and language checks. ChangesPreset site pages
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~30 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant SiteFacts
participant LanguageConfig
participant filledLanguages
participant withPresetPages
participant viewFor
participant presetTemplate
SiteFacts->>filledLanguages: provide registered preset facts
LanguageConfig->>filledLanguages: provide localized preset text
filledLanguages->>withPresetPages: add localized preset pages
withPresetPages-->>filledLanguages: return expanded languages
filledLanguages->>viewFor: provide page data
viewFor->>presetTemplate: render preset page view
Suggested labels: Merge Risk: ⚪ Minimal · up to The preset pages have no established issue requiring a fix before merge; normal checks remain appropriate. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new pages have identifiable validation and rendering controls, and this review found no demonstrated new security exposure. Publication behavior remains insufficiently established to rate the design risk minimal. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 12 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (12 passed)
Full details: Clear User-Facing TextExplanation The Polish preset page names the same concept inconsistently. The title uses “Walidacja uploadu”, while the lead and description use “formularz przesyłania”. The presets page and metadata also mix “uploadu” and “przesyłania”. Resolution Choose one Polish term and use it consistently in the preset title, page title, descriptions, card text, and related metadata. For example, replace the prose uses of “upload” with “przesyłanie” or “przesyłania”; keep the stable CLI identifier Full details: Scope, Duplication And DocsExplanation The PR introduces a duplicate byte-grouping helper. Resolution Remove Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
What changes
/presets/and/pl/presety/list the presets. Each preset has its own page in both languages: the question it answers, what it usually catches, what the set holds at its defaults, how many files the system under test shouldaccept,rejector decide on (unspecified), every setting with what it takes and its default, and the commands to run it (preset show,generate --preset,preset eject,extends: preset:<id>).Where the numbers come from
Nothing on a preset page is typed. Settings come from the registry, the budget from
tfg preset show --json, the reactions from a dry run of the set, both asked in process by the guard. The pages are made from the registry after the language text is filled in, so a new preset gets its pages without anybody adding them, and without its Polish words the render stops and names it.Guards
TestEveryPresetIsDescribedInEveryLanguage- the English question, title, catches and setting descriptions are the registry's own words (the questions had been copies nothing compared), the Polish page carries as many catches and the same settings.TestEveryReactionHasItsMeaningInEveryLanguage- every outcome a manifest can declare has its meaning in every language.TestTheSitemapNeedsNoSchemaButItsOwncounts the rendered pages rather than the ones the language files list, and asserts it reached the made pages.TestEveryLanguageDescribesEverythingTheProgramCanProduceasks for the words of every format setting's shape.How to see it
then open
web/public/presets/size-boundaries/index.htmlthrough a local server. Measured: 26 addresses in the sitemap, titles 50-59 characters, descriptions 149-164, no page scrolls sideways at 375 px, every command on the new pages runs.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Improvements