-
-
Notifications
You must be signed in to change notification settings - Fork 2
site: add the corrupt-files and CI guides to the header and footer menu #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,16 +58,14 @@ | |
| "slug": "beschadigde-testbestanden", | ||
| "nav": "Beschadigde bestanden", | ||
| "title": "Beschadigde testbestanden - kapotte bestanden op exacte grootte", | ||
| "description": "Een bestand dat met opzet kapot is, op exacte grootte, met een manifest dat zegt dat je systeem het moet weigeren. Voor het testen van uploadvalidatie en parsers.", | ||
| "parent": "use-cases" | ||
| "description": "Een bestand dat met opzet kapot is, op exacte grootte, met een manifest dat zegt dat je systeem het moet weigeren. Voor het testen van uploadvalidatie en parsers." | ||
| }, | ||
| { | ||
| "key": "ci", | ||
| "slug": "testbestanden-in-ci", | ||
| "nav": "Testbestanden in CI", | ||
| "title": "Testbestanden in CI - GitHub Actions, GitLab CI en PowerShell", | ||
| "description": "Genereer testbestanden in de pipeline in plaats van binaire bestanden te committen: GitHub Actions-workflow, GitLab-job, afsluitcodes en de PowerShell-valkuil.", | ||
| "parent": "use-cases" | ||
| "description": "Genereer testbestanden in de pipeline in plaats van binaire bestanden te committen: GitHub Actions-workflow, GitLab-job, afsluitcodes en de PowerShell-valkuil." | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win 🔎 Supported by static analysis🏁 Script executed: rg -n -C 3 'Keep a pull request focused|one subject' CONTRIBUTING.md
git diff f2acc41e70de2309c3e44cdb5752d78462064a17..e4350767299be916683b99a97c25432755d3d50d -- web/content/nl/site.jsonRepository: donislawdev/TestingFilesGenerator Length of output: 1981 Move the Dutch description rewrite to a separate PR, or revert it. This PR removes 🤖 Prompt for AI Agents |
||
| } | ||
| ], | ||
| "words": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the inconsistent address form in the
damagedescription.The change switches this description to formal address ("Ihr System"). The other German descriptions use informal address, for example "dein System" on the
indexpage and "erzeugst du" on thedocspage. This change is unrelated to the PR goal of removingparent. It also makes the German site inconsistent. Use the informal form, or move the change to a separate PR.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions