Open
Conversation
- Overhead evaluation is disabled by default, but the corresponding code is not yet removed. - Obsolete attribute added to WithEvaluateOverhead
timcassell
requested changes
Feb 15, 2026
| @@ -10,7 +10,9 @@ namespace BenchmarkDotNet.Attributes | |||
| [PublicAPI] | |||
| public class EvaluateOverheadAttribute : JobMutatorConfigBaseAttribute | |||
Collaborator
There was a problem hiding this comment.
This should also be deprecated (you can remove the pragma when that's done).
Author
There was a problem hiding this comment.
Updated, also added a few more pragma warnings for the tests failing, so it should build correctly.
| return Array.Empty<Summary>(); | ||
| } | ||
|
|
||
| #pragma warning disable CS0618 // WithEvaluateOverhead is obsolete |
Collaborator
There was a problem hiding this comment.
Only put the pragmas around the line with the obsolete call.
Author
There was a problem hiding this comment.
I don't think I can do that in this fluent syntax (it was my intention as you suggest here):
Would you prefer to refactor the syntax? Or is there another trick?
|
|
||
| int iterationCount = baselineJob.Run.IterationCount; | ||
| BenchmarkRunInfo[] benchmarksWithoutInvocationCount = TypeFilter.Filter(effectiveConfig, benchmarksToFilter); | ||
| #pragma warning disable CS0618 // WithEvaluateOverhead is obsolete |
Co-authored-by: Tim Cassell <cassell.timothy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1802