Skip to content

Remove null-forgiving operator (!) in BaseTest.AssertApkSigned #12036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove null-forgiving operator (!) in BaseTest.AssertApkSigned #12036

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
091a9d6
Initial plan
Copilot Jul 11, 2026
138316d
Remove null-forgiving operator in BaseTest.AssertApkSigned
Copilot Jul 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/BaseTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,8 +490,8 @@ protected void AssertApkIsSigned (string apkPath)
UseShellExecute = false,
CreateNoWindow = true,
};
using var proc = Process.Start (psi);
string stdout = proc!.StandardOutput.ReadToEnd ();
using var proc = Process.Start (psi) ?? throw new InvalidOperationException ($"Failed to start '{apksignerExe}'.");
string stdout = proc.StandardOutput.ReadToEnd ();
string stderr = proc.StandardError.ReadToEnd ();
proc.WaitForExit ();
Assert.AreEqual (0, proc.ExitCode, $"APK file `{apkPath}` is not signed! apksigner verify failed:\n{stderr}\n{stdout}");
Expand Down
Loading