Remove self-reference from microbuild install and renovate templates

[MiYanni]

Summary

For templates that reference other templates in Arcade, you cannot use @self as multi-repository scenarios may have self be a repository without Arcade in it. Therefore, the literal path here should be used. The @ syntax should only be used if you're crossing a repository boundary (meaning, you need to explicitly denote files from a different repository).

[akoeplinger]

there are a lot more template inclusions with @self, should we fix them all?

[MiYanni]

@akoeplinger Technically, yes. I just know that this one that was added currently blocks dotnet/workload-versions from building.

[akoeplinger]

@MiYanni I think I'd prefer being consistent and removing the @self everywhere then

[mmitche]

@MiYanni I think I'd prefer being consistent and removing the @self everywhere then

Yep agreed.

[mmitche]

Let's be consistent and change these throughout the repo.

For my education...when the template path is rooted like /<> and you have multiple repos checked out, does the YAML expansion know that / is related to arcade and not to the root source directory?

[MiYanni]

Let's be consistent and change these throughout the repo.

For my education...when the template path is rooted like /<> and you have multiple repos checked out, does the YAML expansion know that / is related to arcade and not to the root source directory?

It depends who's activating it. In a majority of cases, your pipeline template (top-level yml file) needs to care about using @ notation. But if you reference template: /foo/bar/baz.yml@ABC, you're setting the context of that template to the repo alias of ABC. Then, any other template: /whatever calls will be in the context of ABC.

It is kinda like using cd in command prompt. If your working directory is C:\foo\bar which is the C drive, you cannot cd to D:\bim\bam on the D drive because you're going across a drive boundary. You gotta change the context to cd D: and then you can move to that directory or any directories on D. If you need stuff from C, you gotta move back to the C context again. It isn't a 1-to-1 comparison, but it is similar to that in operation.

@ symbol indicates a context change for templates. So, everything in Arcade references only directories within Arcade, it doesn't need to use @.

[MiYanni]

@copilot Please remove all @self references from Azure Pipeline yml files for template: nodes within the repo.

[Copilot]

@MiYanni I've opened a new pull request, #16568, to work on those changes. Once the pull request is ready, I'll request review from you.

[MiYanni]

@mmitche Had copilot do all the @self references. Put a comment above for ya explaining how it works. Need a re-review to merge. I've set the PR to auto-merge.

[Copilot]

@mmitche I've opened a new pull request, #16572, to work on those changes. Once the pull request is ready, I'll request review from you.

[akoeplinger]

turns out we really only had renovate.yml and the microbuild one that fell into the templates-extending-templates case

stale