Open
Conversation
Member
Author
am11
commented
Mar 3, 2026
| __freebsd_major_version=$("$rootfsDir"/bin/freebsd-version | cut -d'.' -f1) | ||
| nonPortableRid="freebsd.$__freebsd_major_version-${targetArch}" | ||
| elif [ "$targetOs" = "openbsd" ]; then | ||
| nonPortableRid="openbsd.$(uname -r)-${targetArch}" |
Member
Author
There was a problem hiding this comment.
@sethjackson, it depends on general compat of platform. On FreeBSD, we only use major version. If we want the same, then it would become:
Suggested change
| nonPortableRid="openbsd.$(uname -r)-${targetArch}" | |
| nonPortableRid="openbsd.$(uname -r | cat -d'.' -f1)-${targetArch}" |
Contributor
There was a problem hiding this comment.
AFAIK OpenBSD is not generally considered ABI compatible from point release to point release.
Eg. for 7.8 -> 7.9 things may work but there are no guarantees that they will.
I think the first option:
nonPortableRid="openbsd.$(uname -r)-${targetArch}"
Is the best one.
uname -r will give back 7.8
So then the RID will be something like:
openbsd.7.8-x64
It might be nice to have:
openbsd-78-x64
instead but regardless I'm good here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed in the previous PR.