Repository navigation
Return devProxy.crt filename for rootCertificate format=crt - #2087
Open
waldekmastykarz wants to merge 1 commit into
Open
waldekmastykarz wants to merge 1 commit into
waldekmastykarz wants to merge 1 commit into
Conversation
Closes dotnet#2068 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change aligning the root certificate download filename with the requested crt format.
No open issues 🎉
What changed in this PR
Aligns the root certificate download filename with the requested crt format, keeping the change minimal to avoid conflicts with parallel work.
Changes:
- Returns
devProxy.crtinstead ofdevProxy.pemforGET /proxy/rootCertificate?format=crt. - Leaves the PEM-encoded certificate content and content type unchanged.
| File | Description |
|---|---|
DevProxy/ApiControllers/ProxyController.cs |
Updates the root certificate download filename to devProxy.crt. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the
Content-Dispositionfilename returned byGET /proxy/rootCertificate?format=crtwith the requested format (devProxy.crtinstead ofdevProxy.pem). The content is unchanged (PEM-encoded certificate, which is the common encoding for.crtfiles).Kept intentionally minimal to avoid conflicts with the parallel work on #2067.
Closes #2068