Repository navigation
Exclude internal message types from ExecutionSummaryPlugin report - #2088
Open
waldekmastykarz wants to merge 2 commits into
Open
waldekmastykarz wants to merge 2 commits into
waldekmastykarz wants to merge 2 commits into
Conversation
Timestamp, FinishedProcessingRequest and Skipped logs were falling into an "Unknown" category (with timestamps and URLs as keys). Map all message types explicitly in a single shared helper: exclude proxy-internal and diagnostic types, and map Normal/Processed to proper categories. Adds regression tests. Closes dotnet#2078 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new orphaned-log bucket-creation path lacks a regression test verifying the URL, category, and count for a PassedThrough log without a preceding InterceptedRequest.
1 open issue
What changed in this PR
Fixes the execution-summary regression by excluding internal logs that produced misleading Unknown categories, while preserving the report shape.
Changes:
- Centralizes category mapping, excludes diagnostic messages, and adds categories for
NormalandProcessed. - Makes URL grouping tolerate logs without a preceding intercepted-request log.
- Adds regression tests for internal-message filtering in both grouping modes.
| File | Description |
|---|---|
| DevProxy.Plugins/Reporting/ExecutionSummaryPluginReportBase.cs | Defines shared category mapping and filters summary totals. |
| DevProxy.Plugins/Reporting/ExecutionSummaryPlugin.cs | Uses shared filtering and safely creates URL groups. |
| DevProxy.Integration.Tests/ReportingPluginsIntegrationTests.cs | Tests internal-message exclusion for URL and message-type grouping. |
Review effort: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the regression of #416 where ExecutionSummaryPlugin reported pass-through requests with an extra
Unknowncategory whose keys were timestamps and URLs.Cause
The engine now records
TimestampandFinishedProcessingRequestlogs for every request (and plugins logSkipped/Processed/Normal), which all hit the_ => "Unknown"fallback.Changes
ExecutionSummaryPluginReportBase(was duplicated in the plugin and report).InterceptedResponse,Timestamp,FinishedProcessingRequest,Skipped(proxy-internal / diagnostic).Normal→Information,Processed→Requests processed.urlandmessageTypegrouping (verified failing before the fix).Timestamps are dropped rather than moved into a
timestampsarray to keep the report shape unchanged.Resolves #2078
Closes #2097