-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Update security docs to address outdated cryptographic defaults, broken samples, and weak recommendations #53164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jeffhandley
wants to merge
21
commits into
dotnet:main
Choose a base branch
from
jeffhandley:jeffhandley/outdated-recommendations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f4d3143
Add OWASP-aligned PBKDF2 iteration guidance and password hashing context
jeffhandley 3e12992
Modernize AES encryption snippets and add CBC mode warnings
jeffhandley 457c5df
Replace 1024-bit RSA and PKCS#1 v1.5 with 2048-bit RSA and OAEP
jeffhandley b70d56b
Add deprecation warnings for legacy crypto algorithms and APIs
jeffhandley 62c2f8e
Fix correctness bugs in crypto code samples
jeffhandley acfaaeb
Address PR review feedback
jeffhandley 0fbb4be
Revert DPAPI RNG to RNGCryptoServiceProvider for net461 compat
jeffhandley e440169
Address second round of PR review feedback
jeffhandley b5e2bbd
Fix RSACryptoServiceProvider obsoletion wording in hardware encryptio…
jeffhandley a356a6b
Add VB DPAPI project file and re-apply fixes
jeffhandley a512d7a
Restore hard-coded sample keys with illustration comments
jeffhandley 59997bc
Address reviewer feedback: NIST over OWASP, no algorithm names, no AE…
jeffhandley a85b170
Address additional reviewer feedback on RSA key sizes and RNG wording
jeffhandley 2309655
Modernize hardware encryption sample: SHA-1 to SHA-256, add disposal
jeffhandley cc3f5e8
Remove remaining AES-GCM reference and soften algorithm recommendations
jeffhandley 1e65834
Align broader security docs with current NIST guidance
jeffhandley ea76609
Tighten remaining security compatibility docs
jeffhandley a812155
Remove remaining AES-GCM recommendations
jeffhandley 2840c50
Fix DPAPI sample analyzer failures
jeffhandley 20355a3
Fix CryptoWalkThru partial reads
jeffhandley cb76bf4
Apply feedback (top half)
bartonjs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain this is true because IIRC TLS 1.3 says that if both side can talk TLS 1.3 they MUST talk TLS 1.3 and IIRC we did add support for TLS 1.3. Possibly more generic statement will be better here. @bartonjs ideas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recommendation is correct: Set your protocols to None, which SslStream interprets as "no preference, do whatever the OS says". And that's as far of an opinion as this document should have.