Open
Conversation
Agent-Logs-Url: https://github.com/dotnet/ef6/sessions/4eda9619-131a-40c9-9b63-af1987a77e41 Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
AndriySvyryd
May 4, 2026 22:32
View session
There was a problem hiding this comment.
Pull request overview
This PR retargets the EF6 command-line/tooling assets from .NET 6 to .NET 8 so the packaged tooling in EntityFramework stays on a supported runtime while keeping the rest of the package layout aligned.
Changes:
- Retargets the
ef6tool project and the NuGet packaging project fromnet6.0tonet8.0. - Updates NuGet package tool paths and the PMC PowerShell launcher to use
tools/net8.0/any/. - Renames the framework-specific
buildandbuildTransitivewrapper assets fromnet6.0tonet8.0.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/EntityFramework.NuGet/tools/EntityFramework6.psm1 |
Updates the PMC launcher to invoke the net8.0 tool assembly. |
src/EntityFramework.NuGet/EntityFramework.NuGet.nuspec |
Repoints packaged tool artifacts from tools/net6.0 to tools/net8.0. |
src/EntityFramework.NuGet/EntityFramework.NuGet.csproj |
Retargets the packaging project and updates the conditional build-tasks reference. |
src/EntityFramework.NuGet/buildTransitive/net8.0/EntityFramework.targets |
Renamed transitive wrapper target import for the new TFM folder. |
src/EntityFramework.NuGet/buildTransitive/net8.0/EntityFramework.props |
Renamed transitive wrapper props import for the new TFM folder. |
src/EntityFramework.NuGet/build/net8.0/EntityFramework.targets |
Adds the net8-specific build wrapper target import. |
src/EntityFramework.NuGet/build/net8.0/EntityFramework.props |
Adds the net8-specific props wrapper that enables runtime config generation. |
src/ef6/ef6.csproj |
Retargets the EF6 tool project from net6.0 to net8.0. |
Comments suppressed due to low confidence (1)
src/EntityFramework.NuGet/buildTransitive/net8.0/EntityFramework.props:2
- This transitive props asset is now scoped to
net8.0+, so downstreamnet6.0/net7.0projects that only receive EF6 transitively will stop importing the runtime-config generation tweak. Those projects can still restore the package through thenetstandard2.1library asset, but PMC commands against class libraries will regress because no<project>.runtimeconfig.jsonis produced.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net6.0 is EOL; bump the
ef6tool andEntityFramework.NuGetpackaging to targetnet8.0.Changes
ef6.csproj—TargetFrameworks:net6.0;net40;net45→net8.0;net40;net45EntityFramework.NuGet.csproj—TargetFrameworksandItemGroupcondition updated tonet8.0EntityFramework.NuGet.nuspec— tool artifact paths updated:tools/net6.0/any/→tools/net8.0/any/build/net6.0//buildTransitive/net6.0/— directories renamed tonet8.0; import paths inside updated accordinglyEntityFramework6.psm1— hardcoded ef6.dll path updated tonet8.0\any\ef6.dll