Skip to content

Fix FK dependency ordering when replacing owned entities with foreign key references#36769

Closed
Copilot wants to merge 3 commits intorelease/10.0from
copilot/fix-36059
Closed

Fix FK dependency ordering when replacing owned entities with foreign key references#36769
Copilot wants to merge 3 commits intorelease/10.0from
copilot/fix-36059

Conversation

Copy link
Contributor

Copilot AI commented Sep 12, 2025

  • Create new branch copilot/fix-36059-main based on main
  • Cherry-pick test case for FK dependency ordering issue with owned entities
  • Cherry-pick fix for CommandBatchPreparer.CanCreateDependency
  • Push new branch to remote
  • Maintainer to create new PR targeting main from branch copilot/fix-36059-main
  • Run tests to verify fix
  • Perform code review

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits September 12, 2025 23:38
Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
…refinement

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI changed the title [WIP] FK dependency ordering wrong when replacing an inline owned entity Fix FK dependency ordering when replacing owned entities with foreign key references Sep 12, 2025
Copilot AI requested a review from AndriySvyryd September 12, 2025 23:52
@SamMonoRT
Copy link
Member

@AndriySvyryd - closing this draft PR for now. This will need to retargeted from main when ready

@SamMonoRT SamMonoRT closed this Dec 9, 2025
@roji roji deleted the copilot/fix-36059 branch January 5, 2026 17:07
@AndriySvyryd AndriySvyryd restored the copilot/fix-36059 branch February 13, 2026 02:49
@AndriySvyryd AndriySvyryd reopened this Feb 13, 2026
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Rebase on main

Copy link
Contributor Author

Copilot AI commented Feb 13, 2026

@copilot Rebase on main

I've successfully rebased the branch onto main (commit cda09ad). The three commits from the original PR have been rebased on top of origin/main. However, I'm unable to force-push the rebased commits to update the remote branch. You'll need to manually force-push the rebased branch or update the PR's base branch to main.

@AndriySvyryd
Copy link
Member

@copilot Create a new PR targeting main

Copy link
Contributor Author

Copilot AI commented Feb 13, 2026

@copilot Create a new PR targeting main

I've created a new branch copilot/fix-36059-main (commit 27c6d86) based on main with the fix and test case. However, I cannot create PRs or push branches other than the current one due to tool limitations. You'll need to either:

  1. Manually push the local branch: git push origin copilot/fix-36059-main
  2. Or create a new PR from the existing local branch

The branch contains:

  • Test case reproducing the FK dependency issue (b46a14b)
  • Fix for CommandBatchPreparer.CanCreateDependency (ea3f7f0)

Copilot AI added a commit that referenced this pull request Feb 13, 2026
…ed entities

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
@AndriySvyryd
Copy link
Member

Superseded by #37694

@AndriySvyryd AndriySvyryd deleted the copilot/fix-36059 branch February 13, 2026 19:09
Copilot AI added a commit that referenced this pull request Feb 13, 2026
Modified the test to use a proper owned entity (FileEntity) with an FK to a non-owner entity (ContentEntity). The test now properly reproduces issue #36059 and fails without the fix. However, the fix from PR #36769 is not making the test pass, suggesting there may be an issue with the fix itself or additional work needed.

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments