Fix: Named query filters cannot override convention-set filters

[Copilot]

Fix Named Query Filter Override from Convention

• Understand the issue: Named query filters set by conventions cannot be overridden explicitly
• Identify root cause: EntityTypeBuilder.HasQueryFilter(string, LambdaExpression) doesn't set ConfigurationSource
• Fix EntityTypeBuilder.HasQueryFilter to pass ConfigurationSource.Explicit
• Create test to verify conventions can be overridden by explicit configuration
• Run existing tests to ensure no regressions
• Run broader test suite to verify no regressions (611 tests passed)
• Verify the fix with code review and security scan (both passed)
• Address review feedback: Remove QueryFilter constructors without ConfigurationSource
• Make ConfigurationSource property non-nullable

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Cannot Override Named Query Filters Set via Convention</issue_title>
<issue_description>### Bug description

We're in the process of upgrading to EF 10. We have a Convention Set that automatically adds query filters to certain types. We are switching this over to named query filters and have noticed that once the convention sets the filter (with Configuration Source == Convention) that a user cannot override the filter with the same name explicitly

I think this is because of the difference in the code for adding global and named filters:

This code sets the configuration source explicitly:

efcore/src/EFCore/Metadata/Builders/EntityTypeBuilder.cs

Lines 809 to 814 in 4b56ce2

	public virtual EntityTypeBuilder HasQueryFilter(LambdaExpression? filter)
	{
	Builder.HasQueryFilter(filter, ConfigurationSource.Explicit);
	return this;
	}

While this code only calls the QueryFilter constructor and never sets a configuration source.

efcore/src/EFCore/Metadata/Builders/EntityTypeBuilder.cs

Lines 823 to 828 in 4b56ce2

	public virtual EntityTypeBuilder HasQueryFilter(string filterKey, LambdaExpression? filter)
	{
	Builder.HasQueryFilter(new QueryFilter(filterKey, filter));
	return this;
	}

Later on when performing CanSetQueryFilter, the configuration source on the new (explicit) filter is null and thus the old one wins.

Is this intended or is it a bug?

Your code

In a convention:


IConventionEntityTypeBuilder builder = ...;
builder.HasQueryFilter("SomeName", Expression.Lambda(...));


In a user provided configuration:


EntityTypeBuilder<SomeType> builder = ...;
builder.HasQueryFilter("SomeName", s => ...);  // <--- doesn't override


I apologize for the snippets here; it's a bit difficult to provide a full sample with a convention set etc. and I'm not at my desk currently. But if needed I can try and put together the full thing. I was hoping it was just "obviously" intended or a bug

Stack traces

Verbose output

EF Core version

10.0.3

Database provider

No response

Target framework

.NET 10

Operating system

No response

IDE

No response</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Cannot override named query filters set via convention #37708

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[roji]

/cc @AndriySvyryd for ultimate authority

[Copilot]

Pull request overview

This PR fixes a bug where named query filters set by conventions could not be overridden by explicit user configuration. The issue was that the public API method EntityTypeBuilder.HasQueryFilter(string, LambdaExpression) was not passing a ConfigurationSource when constructing the QueryFilter object, preventing proper configuration precedence checks.

Changes:

• Fix EntityTypeBuilder.HasQueryFilter to pass ConfigurationSource.Explicit when creating named query filters, matching the pattern already used for unnamed filters
• Add test verifying explicit configuration can override convention-set named query filters

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/EFCore/Metadata/Builders/EntityTypeBuilder.cs	Add ConfigurationSource.Explicit parameter to QueryFilter constructor for named filters
test/EFCore.Tests/Metadata/Internal/InternalEntityTypeBuilderTest.cs	Add test verifying convention-set named filters can be overridden by explicit configuration

[roji]

@AndriySvyryd possibly take a look at #37708 (comment) while reviewing? Or we can treat that as a separate thing if better.