Skip to content

Update output path for NoneSubstituteTextFiles target to include subdirectory #19176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wallymathieu wants to merge 1 commit into from
+3 −3
Closed

Update output path for NoneSubstituteTextFiles target to include subdirectory #19176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions FSharpBuild.Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
</NoneSubstituteText>
</ItemDefinitionGroup>

<Target Name="NoneSubstituteTextFiles"
Inputs="@(NoneSubstituteText)"
Outputs="@(NoneSubstituteText->'$(IntermediateOutputPath)%(Filename)%(Extension)')"
Copy link
Member

@T-Gro T-Gro Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue on MacOS please?
I am not sure this target is tested much, it can pass the CI while still doing the wrong thing...

Copy link
Contributor Author

@wallymathieu wallymathieu Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got Could not copy the file

For instance:

dotnet build src/fsc/fscArm64Project 
Restore complete (0.6s)
  FSharp.Core netstandard2.0 succeeded (0.1s) → artifacts/bin/FSharp.Core/Debug/netstandard2.0/FSharp.Core.dll
  FSharp.DependencyManager.Nuget netstandard2.0 succeeded (0.1s) → artifacts/bin/FSharp.DependencyManager.Nuget/Debug/netstandard2.0/FSharp.DependencyManager.Nuget.dll
  FSharp.Compiler.Service netstandard2.0 succeeded (0.1s) → artifacts/bin/FSharp.Compiler.Service/Debug/netstandard2.0/FSharp.Compiler.Service.dll
  FSharp.Build netstandard2.0 failed with 1 error(s) (2.1s)
    /usr/local/share/dotnet/sdk/10.0.100/Microsoft.Common.CurrentVersion.targets(5381,5): error MSB3030: Could not copy the file "/Users/mathieu/src/fs/fsharp/artifacts/obj/FSharp.Build/Debug/netstandard2.0/PreRelease/Microsoft.FSharp.Core.NetSdk.props" because it was not found.

I'm trying with dotnet 10.0.101. Seems like I do not get the above error when using that version 😕, so there is that. I'm closing this PR since it seems that it is not needed anymore.

<Target Name="NoneSubstituteTextFiles"
Inputs="@(NoneSubstituteText)"
Outputs="@(NoneSubstituteText->'$(IntermediateOutputPath)%(SubDir)%(Filename)%(Extension)')"
BeforeTargets="AssignTargetPaths;BeforeBuild;GenerateFSharpTextResources">

<ItemGroup>
Expand Down
Loading