WASM benchmark uses WebAssembly SDK and supports CoreClr runtime#5114
WASM benchmark uses WebAssembly SDK and supports CoreClr runtime#5114ilonatommy wants to merge 4 commits intomainfrom
Conversation
Microsoft.NET.Sdk.WebAssembly and support CoreClr runtime
dotnet/BenchmarkDotNet#2998
|
We should migrate away from using Some of the configurations from this repository should probably be part of the BDN template as well
Are these VFS items applied correctly ? |
WasmMainJSPath is compatible with Wasm Sdk|
/ba-g failures not connected |
|
/ba-g failures not connected |
|
Taking a look at this, hoping to have an update later today that completes some of the other cleanup things to merge this (updating BDN version we use, fixing some errors, etc). |
|
I am still working on some of the finishing touches and one issue we are hitting on the wasm wasm runs. I have put up a draft PR here: #5123 with the test run through the 'Setup Testing' commit available here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2907458&view=results. The test run ran wasm aot successfully but the Wasm Wasm test run hit the following issue when attempting to run the benchmark: Here is the summarization of my current investigation to solve this:Summary of changes and remaining issue for PR Changes made (performance repo side)
Remaining issue: benchmark-main.mjs not found The WASM AOT runs (codeGenType: 'aot') succeed because they use Microsoft.NET.Sdk.WebAssembly, which provides the full WASM build pipeline (WasmBuildApp, StaticWebAssets, The non-AOT CoreCLR runs (codeGenType: 'wasm' with --wasm-coreclr) fail because BDN's WasmGenerator switches the SDK from Microsoft.NET.Sdk.WebAssembly to string sdkName = runtime.IsMonoRuntime ? "Microsoft.NET.Sdk.WebAssembly" : "Microsoft.NET.Sdk"; Without Microsoft.NET.Sdk.WebAssembly:
This likely needs a BDN fix: the CoreCLR WASM path probably still needs Microsoft.NET.Sdk.WebAssembly as the SDK (which handles the build pipeline), but with /end summarizationIf y'all have any ideas on what the cause may be the help would be appreciated, otherwise I plan on attempting to repro this locally tomorrow to verify that the wwwroot is not being published at all and further investigate. |
Yes |
Should be merged together with dotnet/BenchmarkDotNet#2998.