Skip to content

Fix MAUI Android inner loop MSBuild arg splitting on Helix #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LoopedBard3 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MAUI Android inner loop MSBuild arg splitting on Helix #5285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions eng/performance/maui_scenarios_android_innerloop.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'mono'">/p:UseMonoRuntime=true</_MSBuildArgs>
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">/p:UseMonoRuntime=false</_MSBuildArgs>

<!-- CoreCLR: disable ReadyToRun so inner loop measures JIT behavior -->
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">$(_MSBuildArgs);/p:PublishReadyToRun=false;/p:PublishReadyToRunComposite=false</_MSBuildArgs>
<!-- CoreCLR: disable ReadyToRun so inner loop measures JIT behavior.
Use spaces (not ';') to separate args: _MSBuildArgs is passed as a
single quoted argument in the Helix PreCommands/Command, and Helix
treats ';' as a command separator when generating the run script
(that's why the env-var 'set ...;set ...' blocks work). A ';' here
would split the quoted argument across separate command lines. -->
<_MSBuildArgs Condition="'$(RuntimeFlavor)' == 'coreclr'">$(_MSBuildArgs) /p:PublishReadyToRun=false /p:PublishReadyToRunComposite=false</_MSBuildArgs>

<!-- AndroidRid: defaults based on target OS but can be overridden.
Windows targets physical devices; Linux targets emulators. -->
Expand Down