BigInteger -> double fix #122207
Open
BigInteger -> double fix #122207
+11
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-numerics |
huoyaoyuan
reviewed
Dec 5, 2025
Member
huoyaoyuan
left a comment
huoyaoyuan
left a comment
There was a problem hiding this comment.
Can you add corresponding test cases?
| ulong m = length > 1 ? bits[length - 2] : 0; | ||
| ulong l = length > 2 ? bits[length - 3] : 0; | ||
| if (length > 3 && bits.AsSpan()[..^3].ContainsAnyExcept(0u)) { | ||
| l |= 1; // sticky bit |
Member
There was a problem hiding this comment.
This should be deciding the carrying. Can you include more description of the rule, like the soft FP methods in Half and BFloat16?
| } | ||
|
|
||
| return NumericsHelpers.GetDoubleFromParts(sign, exp, man); | ||
| // NumericsHelpers.GetDoubleFromParts does not handle rounding correctly here |
Member
There was a problem hiding this comment.
Since GetDoubleFromParts is removed, the comment should be like "leverage FPU to do correct rounding for man*2^exp"
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49611