Switch ilasm to Antlr4BuildTasks#124764
Merged
jkoritzinsky merged 6 commits intodotnet:mainfrom Mar 2, 2026
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
jkoritzinsky
requested changes
Feb 23, 2026
This was referenced Feb 24, 2026
Member
Author
|
@jkoritzinsky, generated code is now checked in. Added |
Member
|
Thank you! I'll add the missing packages to the mirror feed tomorrow. |
This was referenced Feb 24, 2026
Open
akoeplinger
reviewed
Feb 24, 2026
Member
Author
|
I have added a post-processing workaround for kaby76/Antlr4BuildTasks#120. When it will be released, we can update the version and remove the workaround. |
jkoritzinsky
approved these changes
Feb 28, 2026
akoeplinger
approved these changes
Mar 2, 2026
Member
|
I'll merge this once dotnet/source-build-reference-packages#1585 is in. |
Member
|
we disabled building ilasm.csproj in the VMR so it theoretically doesn't need to be tied to that |
Member
|
/ba-g timeouts and WBT failures are unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.