Skip to content

Update .gitignore to include cache and dump files#126718

Open
jtschuster wants to merge 1 commit intomainfrom
users/jtschuster/gitignore-lscache-and-dumps
Open

Update .gitignore to include cache and dump files#126718
jtschuster wants to merge 1 commit intomainfrom
users/jtschuster/gitignore-lscache-and-dumps

Conversation

@jtschuster
Copy link
Copy Markdown
Member

Add patterns to ignore C# Dev Kit caches and dump files.

The Dev Kit extension now creates .lscache files for each csproj loaded by the lsp. We should tell git to ignore them

Also ignore dump files because I imagine people often have them in the directory but never want to commit them.

Add patterns to ignore C# Dev Kit caches and dump files.
@jtschuster jtschuster self-assigned this Apr 9, 2026
Copilot AI review requested due to automatic review settings April 9, 2026 16:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Note

This review was generated by Copilot.

🤖 Copilot Code Review — PR #126718

Holistic Assessment

Motivation: Justified — .lscache (C# Dev Kit), .dmp, and .dump files are common development/debugging artifacts that should not be committed. This is a quality-of-life improvement for contributors using VS Code with C# Dev Kit and anyone generating crash/memory dumps locally.

Approach: Correct — adding glob patterns to .gitignore is the standard approach. The entries are placed logically after the existing VS Code section, which makes sense since C# Dev Kit is a VS Code extension.

Summary: ✅ LGTM. This is a small, safe, well-placed addition to .gitignore. No existing tracked files match the new patterns, and the glob patterns are appropriately scoped. No code changes, no build/test impact.


Detailed Findings

✅ Correctness — No tracked files affected

Verified via git ls-files '*.lscache' '*.dmp' '*.dump' that no existing tracked files match these patterns. The new entries will only affect future untracked files.

✅ Placement — Logically organized

The .lscache entry is placed immediately after the VS Code section (.vscode entries), which is appropriate since C# Dev Kit is a VS Code extension. The dump file entries are grouped together with a clear comment. Both new blocks are between the VS Code and MonoDevelop sections, maintaining the file's organizational structure.

✅ Pattern scope — Appropriately broad

  • *.lscache is specific to C# Dev Kit language server caches.
  • *.dmp and *.dump are standard dump file extensions. While broad, these are universally recognized as debug/crash artifacts and the repo has no legitimate use of these extensions (no tracked files match). This is consistent with other broad patterns already in the file (e.g., *.log, *.tmp, *.pdb).

Generated by Code Review for issue #126718 ·

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants