Consolidate area labels: merge area-Single-File and area-HostModel into area-Host#126734
Consolidate area labels: merge area-Single-File and area-HostModel into area-Host#126734
Conversation
…oRun-coreclr Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/b71e4180-f675-47c0-9a0b-b1d094444066 Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/84a62a2a-6c33-473f-9208-8f6e58b24c93 Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/3bd31aa8-4931-4574-98e9-e0c13e3c5cbd Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
|
Tagging subscribers to this area: @agocke, @jeffschwMSFT, @elinor-fung |
There was a problem hiding this comment.
Pull request overview
Consolidates area-label documentation and triage heuristics by merging area-Single-File and area-HostModel guidance into area-Host, so Host-related ownership and labeling guidance is centralized.
Changes:
- Updates
area-Hostownership description and removesarea-Single-File/area-HostModelrows from the area owners table. - Updates issue-triage heuristics to route single-file deployment issues to
area-Host. - Also changes Crossgen/R2R label guidance to use
area-crossgenand removes thearea-ReadyToRun-coreclrrow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
docs/area-owners.md |
Removes area-Single-File/area-HostModel entries and expands area-Host scope; also adjusts Crossgen/ReadyToRun-related entries. |
.github/skills/issue-triage/references/area-label-heuristics.md |
Updates quick-reference heuristics to map single-file (and other terms) to area-Host, and updates Crossgen/R2R heuristic label. |
| | area-Codegen-LLVM-mono | @steveisok | | | | ||
| | area-Codegen-meta-mono | @steveisok | | | | ||
| | area-crossgen2-coreclr | @agocke | @dotnet/crossgen-contrib | | | ||
| | area-crossgen | @agocke | @dotnet/crossgen-contrib | | |
There was a problem hiding this comment.
This change renames the documented label from area-crossgen2-coreclr to area-crossgen, but the PR description/title are about consolidating Host labels. Please confirm this rename is intentional and that area-crossgen is the actual label used for triage; otherwise, revert to the existing label name to avoid breaking label guidance.
| | area-GC-mono | @agocke | @BrzVlad | @agocke to consult | | ||
| | area-Host | @agocke | @jeffschwMSFT @elinor-fung | Issues with dotnet.exe including bootstrapping, framework detection, hostfxr.dll and hostpolicy.dll | | ||
| | area-HostModel | @agocke | @elinor-fung | | | ||
| | area-Host | @agocke | @jeffschwMSFT @elinor-fung | Issues with dotnet.exe including bootstrapping, framework detection, hostfxr.dll, hostpolicy.dll, host model, and single-file deployment | |
There was a problem hiding this comment.
area-Single-File and area-HostModel are removed from this table, but @dotnet-policy-service configuration still references both labels (in .github/policies/resourceManagement.yml). If these labels are being consolidated into area-Host, the policy mapping/notifications should be updated accordingly; otherwise issues/PRs labeled with the old areas will still route separately and this table will be out of sync with automation.
| | area-R2RDump-coreclr | @agocke | | | | ||
| | area-ReadyToRun-coreclr | @agocke | | | | ||
| | area-Serialization | @StephenMolloy | @StephenMolloy @dotnet/Tellurium | Packages:<ul><li>System.Runtime.Serialization.Xml</li><li>System.Runtime.Serialization.Json</li><li>System.Private.DataContractSerialization</li><li>System.Xml.XmlSerializer</li></ul> Excluded:<ul><li>System.Runtime.Serialization.Formatters</li></ul> | |
There was a problem hiding this comment.
The area-ReadyToRun-coreclr row was removed (now there is no explicit owner entry for that label in this document). Please confirm the label has been retired/renamed (e.g., covered by area-crossgen) or add back an explicit row so owners can still be identified for ReadyToRun/R2R issues.
| | JIT, code generation, inlining, tiered compilation | `area-CodeGen-coreclr` | | ||
| | NativeAOT, ahead-of-time compilation | `area-NativeAOT-coreclr` | | ||
| | Crossgen2, R2R, ReadyToRun | `area-crossgen2-coreclr` | | ||
| | Crossgen2, R2R, ReadyToRun | `area-crossgen` | |
There was a problem hiding this comment.
This updates the heuristic from area-crossgen2-coreclr to area-crossgen, which is unrelated to the Host label consolidation described in the PR metadata. Please confirm the label rename is intentional and that area-crossgen is the correct label used in the repo; otherwise this guidance will point triage to a non-existent label.
| | Interop, COM, P/Invoke, marshalling (runtime) | `area-Interop-coreclr` | | ||
| | Host, `dotnet` executable, hostfxr, hostpolicy | `area-Host` | | ||
| | Single-file deployment | `area-Single-File` | | ||
| | Host, `dotnet` executable, hostfxr, hostpolicy, single-file deployment | `area-Host` | |
There was a problem hiding this comment.
Since area-HostModel is being merged into area-Host, consider updating this heuristic text to also mention “host model” explicitly (not just dotnet/hostfxr/hostpolicy/single-file) so triage guidance still covers the merged label scope described in the PR.
Description
Consolidates overlapping area labels into
area-Host:area-Host; row removed, description and heuristics updatedarea-Host; row removed, description updated@vsadovfromarea-HostcontributorsChanges
docs/area-owners.md: Removedarea-Single-Fileandarea-HostModelrows; updatedarea-Hostdescription to cover single-file deployment and host model.github/skills/issue-triage/references/area-label-heuristics.md: Merged single-file deployment heuristic into thearea-Hostline