Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command#126789
Open
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command#126789
Conversation
…ion in sendtohelixhelp.proj Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/03016fca-f49c-41ad-9a70-5edc812bb5d8 Co-authored-by: danmoseley <6385855+danmoseley@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix WasmTestOnChrome build error regarding gen-debug-dump-docs.py
Fix WasmTestOnChrome: exclude browser/wasi from gen-debug-dump-docs.py helix post-command
Apr 11, 2026
This was referenced Apr 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes WASM Helix job failures by preventing gen-debug-dump-docs.py from being added as a Helix post-command on browser/wasi targets, where that script is not present in the correlation payload. The change aligns the post-command gating with the existing TestEnvFileName OS-exclusion pattern already used in the same project file.
Changes:
- Update the non-Windows
HelixPostCommandscondition to excludebrowserandwasi, avoiding a missing-script failure on those targets.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/sendtohelixhelp.proj | Excludes browser/wasi from the non-Windows gen-debug-dump-docs.py Helix post-command condition to prevent Helix post-step failures on WASM jobs. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WasmTestOnChromeand related WASM CI jobs were failing becausegen-debug-dump-docs.pywas scheduled as a Helix post-command for all non-Windows CoreCLR targets, but the script is not present in the correlation payload forbrowser/wasitargets.Changes
src/libraries/sendtohelixhelp.proj: Addedbrowserandwasiexclusions to the non-WindowsHelixPostCommandscondition forgen-debug-dump-docs.py, consistent with the existing pattern already used forTestEnvFileNamein the same file:Changes
src/libraries/sendtohelixhelp.projTesting
Change is a build/CI pipeline configuration fix; validated by inspection against the existing pattern in the same file.
Fixes #126706