Add CompositeMLDsa CNG (NCrypt)#130053
Draft
PranavSenthilnathan wants to merge 4 commits into
Draft
Conversation
Contributor
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @dotnet/area-system-security |
vcsjones
reviewed
Jul 1, 2026
vcsjones
reviewed
Jul 1, 2026
bartonjs
reviewed
Jul 2, 2026
| throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
| protected override int ExportCompositeMLDsaPrivateKeyCore(Span<byte> destination) => | ||
| CngPkcs8.AllowsOnlyEncryptedExport(_key) | ||
| ? throw new CryptographicException(SR.Cryptography_KeyNotExtractable) |
Member
There was a problem hiding this comment.
How exactly is Windows failing? If they're giving an HR saying "no workey", then let's just go ahead and call them how we expect to, and maybe we don't have to come back and wire it up.
If they're A/V-ing or something, then, sure, throwing here is good.
Repeats to other places with the same check.
Member
Author
There was a problem hiding this comment.
Windows returns an error code for unsupported algo and we wrap it in an exception with an appropriate message.
| /// <value> | ||
| /// An object that specifies the Composite ML-DSA family of algorithms. | ||
| /// </value> | ||
| [Experimental(Experimentals.PostQuantumCryptographyDiagId, UrlFormat = Experimentals.SharedUrlFormat)] |
Member
There was a problem hiding this comment.
I assume the [Experimental] is because the feature is only in insiders right now?
Member
There was a problem hiding this comment.
The whole ietf-lamps-pq-composite-sigs is still a draft RFC.
| /// <inheritdoc/> | ||
| protected override int SignDataCore(ReadOnlySpan<byte> data, ReadOnlySpan<byte> context, Span<byte> destination) => | ||
| throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
| protected override int SignDataCore(ReadOnlySpan<byte> data, ReadOnlySpan<byte> context, Span<byte> destination) |
| /// <inheritdoc/> | ||
| protected override int ExportCompositeMLDsaPrivateKeyCore(Span<byte> destination) => | ||
| throw new PlatformNotSupportedException(SR.Format(SR.Cryptography_AlgorithmNotSupported, nameof(CompositeMLDsa))); | ||
| protected override bool VerifyDataCore(ReadOnlySpan<byte> data, ReadOnlySpan<byte> context, ReadOnlySpan<byte> signature) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up Composite ML-DSA CNG support.
The APIs in #130052 is pending approval so they're internal in this PR.
PKCS8 export does not work in Windows for Composite ML-DSA (yet), so encrypted export only keys can't currently be exported. Also, PKCS8 export is done by exporting the private key instead.