Skip to content

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016161#130100

Open
dotnet-bot wants to merge 2 commits into
mainfrom
locfiles/1f57358d-4ae4-4302-bff9-9f0db48a1af9
Open

Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016161#130100
dotnet-bot wants to merge 2 commits into
mainfrom
locfiles/1f57358d-4ae4-4302-bff9-9f0db48a1af9

Conversation

@dotnet-bot

Copy link
Copy Markdown
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

@github-actions

This comment has been minimized.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012738 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012782 Jul 1, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012782 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012800 Jul 1, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012800 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012844 Jul 1, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012844 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012890 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012890 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012935 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3012935 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013170 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013170 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013231 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013231 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013251 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013251 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013274 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013274 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013287 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013287 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013327 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013327 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013362 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013362 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013378 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013378 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013393 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013393 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013448 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013448 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013487 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013487 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013504 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013504 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013523 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013523 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013535 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013535 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013550 Jul 2, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013550 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013661 Jul 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013661 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013753 Jul 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013753 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013778 Jul 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013778 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013801 Jul 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013801 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3013819 Jul 3, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3014194 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3014907 Jul 5, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3014907 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3014954 Jul 5, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3014954 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015227 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015227 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015287 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015287 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015462 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015462 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015483 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015483 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015496 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015496 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015508 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015508 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015532 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015532 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015547 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015547 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015595 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015595 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015615 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015615 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015744 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015744 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015766 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015766 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015782 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015782 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015794 Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Copilot Code Review

Holistic Assessment

Motivation: Automated localization check-in by OneLocBuild. Two sets of changes: (1) translations for 12 new source-generator strings in System.Runtime.InteropServices and (2) cleanup of 2 orphaned translation entries in System.Text.Json after the SYSLIB1038 diagnostic was removed from main.

Approach: Standard OneLocBuild process — the pipeline adds translations where state="new" and removes translation entries for strings deleted from the source .resx.

Summary: ✅ LGTM. All 26 file changes are consistent and correct. The InteropServices translations preserve format placeholders ({0}, {1}, {2}) and use proper state="translated" transitions. The System.Text.Json deletions are valid cleanup — the source strings (InaccessibleJsonIncludePropertiesNotSupportedFormat and InaccessibleJsonIncludePropertiesNotSupportedTitle) and the SYSLIB1038 diagnostic descriptor were already removed from Strings.resx and JsonSourceGenerator.DiagnosticDescriptors.cs on main.


Detailed Findings

Detailed Findings

✅ InteropServices Translations — Correct state transitions (13 files)

All changes in src/libraries/System.Runtime.InteropServices/gen/Common/Resources/xlf/ follow the expected pattern:

  • <target state="new">English source text</target><target state="translated">Localized text</target>
  • 12 trans-unit IDs updated consistently across all 13 locale files (cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant)
  • Format placeholders ({0}, {1}, {2}) verified present in all translations that require them
  • Strings cover the new COM interface property support diagnostics (InvalidPropertyDeclaration*, MarshalAttributeOnDefaultImplementedComInterfaceMember*, MarshalUsingOnPropertyAccessorMustSpecifyType*, PropertyAccessorsMustBeAllOrNothing*)

✅ System.Text.Json Translation Cleanup — Orphaned entries removed (13 files)

All changes in src/libraries/System.Text.Json/gen/Resources/xlf/ remove 2 trans-unit entries per file:

  • InaccessibleJsonIncludePropertiesNotSupportedFormat
  • InaccessibleJsonIncludePropertiesNotSupportedTitle

Verified against latest main: both Strings.resx and JsonSourceGenerator.DiagnosticDescriptors.cs no longer contain these strings — the SYSLIB1038 diagnostic was removed. The xlf cleanup is correct.

✅ Scope — No code changes

All 26 modifications are confined to .xlf resource files. No source code, tests, project files, or public API surface is affected.

Note

This review was created by GitHub Copilot.

Generated by Code Review for issue #130100 · ● 42.5M ·

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015794 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015819 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015819 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015882 Jul 6, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015882 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015926 Jul 7, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015926 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015968 Jul 7, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3015968 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016068 Jul 7, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016068 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016083 Jul 7, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016083 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016102 Jul 7, 2026
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016102 Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 3016161 Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant