Ignore AssociatedSourceType on UnmanagedCallersOnly in CoreCLR#130270
Ignore AssociatedSourceType on UnmanagedCallersOnly in CoreCLR#130270MichalStrehovsky with Copilot wants to merge 15 commits into
Conversation
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
|
Tagging subscribers to this area: @agocke |
|
@copilot same problem with mono: * Assertion at /__w/1/s/src/mono/mono/metadata/marshal.c:3478, condition `is_ok (error)' not met, function:mono_marshal_set_callconv_from_unmanaged_callers_only_attribute, Binary format of the specified custom attribute was invalid. assembly: type:UnmanagedCallersOnlyBasicTest member:(null) |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Addressed in 1ae3051. The broad Mono custom-attribute parser rewrite was removed; the Mono diff now only skips the narrow |
|
@copilot is the bug on the Mono side in |
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Addressed in af7862f. I removed the |
CoreCLR rejected
[UnmanagedCallersOnly]attributes containing the newerAssociatedSourceTypenamed argument, throwingMETA_E_CA_UNKNOWN_ARGUMENTwhen setting up unmanaged callbacks. Assemblies valid for NativeAOT could therefore fail under CoreCLR.Runtime
AssociatedSourceTypein CoreCLR’s hand-writtenUnmanagedCallersOnlyAttributeparser.Regression coverage