Fix issue 14624: [PropertyGrid] FolderNameEditor does not use the modern FolderBrowserDialog#14635
Fix issue 14624: [PropertyGrid] FolderNameEditor does not use the modern FolderBrowserDialog#14635SimonZhao888 wants to merge 3 commits into
Conversation
…ern FolderBrowserDialog
There was a problem hiding this comment.
Pull request overview
This PR updates the WinForms design-time FolderNameEditor used by PropertyGrid so it uses System.Windows.Forms.FolderBrowserDialog (which supports the modern/Vista-style folder picker when AutoUpgradeEnabled is enabled), and adjusts related design-time editors and tests accordingly.
Changes:
- Replaced the legacy
FolderNameEditor.FolderBrowserusage withFolderBrowserDialog, and updated returned path handling to useSelectedPath. - Updated
SelectedPathEditor/InitialDirectoryEditoroverrides to match the newInitializeDialogsignature. - Refactored/updated unit + UI integration tests and adjusted shipped public API text for the signature change.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/FolderNameEditor.cs | Switches the editor implementation to FolderBrowserDialog and updates InitializeDialog signature. |
| src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/SelectedPathEditor.cs | Updates override to configure the new dialog type. |
| src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/InitialDirectoryEditor.cs | Updates override to configure the new dialog type. |
| src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt | Updates the shipped API entry for FolderNameEditor.InitializeDialog. |
| src/System.Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/FolderNameEditorTests.cs | Refactors unit tests around the new dialog type/signature. |
| src/test/integration/UIIntegrationTests/FolderNameEditorTests.cs | Updates UI integration test to use FolderBrowserDialog / SelectedPath. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LeafShi1
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have a few concerns — see inline comments.
|
@KlausLoeffelmann we use the modern FolderBrowseDialog to replace the old Dialog, and as we cannot render a tabbed layout within the dialog's UI, and the descriptive information displayed on the old form is no longer applicable to the new one. I need to add a title to the dialog interface to indicate the corresponding attribute. Such as following: |




Fixes #14624
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
14624-before.mp4
After
14624.mp4
Test methodology
Test environment(s)