Fix GroupBox doesn't apply ForeColor in ambient condition by Sathish-087 · Pull Request #14638 · dotnet/winforms

Sathish-087 · 2026-06-11T11:32:28Z

Fixes #9958

Proposed changes

Fixed GroupBox not respecting ambient ForeColor when its own ForeColor is not explicitly set.
Updated rendering logic to fall back to the parent Form.ForeColor instead of defaulting to Visual Styles text color.
Ensured consistency with other controls like Button and Label, which already respect ambient ForeColor.

Customer Impact

Applications that rely on setting ForeColor at the Form level will now see consistent text color in GroupBox.
Improves UI consistency and expected behavior across controls without requiring additional manual overrides.

Regression?

No

Risk

Low
- Change is limited to GroupBox rendering logic.
- Only affects scenarios where ForeColor is not explicitly set on GroupBox.
- Explicit ForeColor settings on GroupBox continue to take precedence.

Screenshots

Before

After

Test methodology

Verified behavior with default GroupBox.ForeColor and custom Form.ForeColor.
Tested explicit override:
- When GroupBox.ForeColor is set, it takes precedence.
Dynamically changed GroupBox.ForeColor at runtime and verified correct updates.
Compared behavior with Button and Label to ensure consistency.
Manually validated rendering with Visual Styles enabled.

Accessibility testing

NA

Test environment(s)

OS: Windows
SDK: 11.0.100-preview.3.26170.106

Microsoft Reviewers: Open in CodeFlow

Added logic to determine foreground color based on the form's ForeColor property.

dotnet-policy-service · 2026-06-11T11:33:53Z

@Sathish-087 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

Copilot

Pull request overview

This PR aims to fix a long-standing WinForms behavior issue where GroupBox does not respect ambient/inherited ForeColor when Visual Styles are enabled, causing the caption text color to fall back to the theme’s default rather than the parent’s ForeColor.

Changes:

Updates GroupBox.OnPaint (Visual Styles path) to pass a text color instead of always deferring to the theme when ForeColor isn’t explicitly set.
Introduces a fallback to Form.ForeColor when it differs from SystemColors.ControlText.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+                if (FindForm() is Form form && form.ForeColor != SystemColors.ControlText)
+                {
+                    GroupBoxRenderer.DrawGroupBox(
+                        e,
+                        new Rectangle(0, 0, Width, Height),
+                        Text,
+                        Font,
+                        form.ForeColor,
+                        textFlags,
+                        gbState);
+                }
+                else
+                {
+                    GroupBoxRenderer.DrawGroupBox(
                    e,
                    new Rectangle(0, 0, Width, Height),
                    Text,
                    Font,
                    textFlags,
                    gbState);
+                }


            else
            {
-                GroupBoxRenderer.DrawGroupBox(
+                if (FindForm() is Form form && form.ForeColor != SystemColors.ControlText)


LeafShi1 · 2026-06-17T07:18:27Z

            else
            {
-                GroupBoxRenderer.DrawGroupBox(
+                if (FindForm() is Form form && form.ForeColor != SystemColors.ControlText)


The fix uses FindForm() which jumps directly to the top-level Form. If the GroupBox is inside a Panel or UserControl that has a custom ForeColor, the ambient color from that intermediate parent is ignored.

WinForms ambient property inheritance walks the full parent chain. this.ForeColor already returns the correct inherited value from any ancestor. A simpler and more correct fix would be to check whether the inherited ForeColor differs from the default

form.ForeColor != SystemColors.ControlText assumes the default form ForeColor is always SystemColors.ControlText. If a high-contrast theme or custom Windows theme changes the default, this comparison could produce incorrect results

LeafShi1 · 2026-06-17T07:22:15Z

                    Font,
                    textFlags,
                    gbState);
+                }


Lines 457-462 (the inner else) have inconsistent indentation — the DrawGroupBox call arguments are not indented relative to the method call, unlike the rest of the file

Sathish-087 added 2 commits June 8, 2026 10:16

Added fix for issue 9958

f40e9bf

Added logic to determine foreground color based on the form's ForeColor property.

Updated the review changes

e90871a

Sathish-087 requested a review from a team as a code owner June 11, 2026 11:32

dotnet-policy-service Bot assigned Sathish-087 Jun 11, 2026

SimonZhao888 requested a review from Copilot June 17, 2026 06:57

Copilot started reviewing on behalf of SimonZhao888 June 17, 2026 06:57 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

LeafShi1 reviewed Jun 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GroupBox doesn't apply ForeColor in ambient condition#14638

Fix GroupBox doesn't apply ForeColor in ambient condition#14638
Sathish-087 wants to merge 2 commits into
dotnet:mainfrom
Sathish-087:Fix_Issue_9958

Sathish-087 commented Jun 11, 2026 •

edited

Loading

Uh oh!

dotnet-policy-service Bot commented Jun 11, 2026

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Uh oh!

LeafShi1 Jun 17, 2026

Uh oh!

LeafShi1 Jun 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Sathish-087 commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Customer Impact

Regression?

Risk

Screenshots

Before

After

Test methodology

Accessibility testing

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

Uh oh!

dotnet-policy-service Bot commented Jun 11, 2026

Contribution License Agreement

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

LeafShi1 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

LeafShi1 Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sathish-087 commented Jun 11, 2026 •

edited

Loading