Skip to content

Fix FatalExecutionEngineError on insert at start of soft-wrapped line in TextBox (#11481) #11641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wnvko-msft wants to merge 4 commits into
base: main
Choose a base branch
from
+16 −0
Open

Fix FatalExecutionEngineError on insert at start of soft-wrapped line in TextBox (#11481) #11641

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb1920a
Fix FatalExecutionEngineError on insert at start of soft-wrapped line…
wnvko-msft May 14, 2026
6f5b635
Always clear line visuals in FormatIncrementalLine
wnvko-msft May 14, 2026
a02ea25
Fix walk-back logic crossing paragraph boundaries in IncrementalMeasu…
wnvko-msft May 20, 2026
90cb096
Fix FatalExecutionEngineError on insert at start of soft-wrapped line…
wnvko-msft May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/documents/TextBoxView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2355,7 +2355,23 @@ private void IncrementalMeasureLinesAfterInsert(double constraintWidth, LineProp
// and mergeable with its predecessor.
if (lineIndex > 0) // we can skip this if line wrap is disabled.
{
int origEndOffset = _lineMetrics[lineIndex - 1].EndOffset;

FormatFirstIncrementalLine(lineIndex - 1, constraintWidth, lineProperties, line, out lineOffset, out endOfParagraph);

// If the predecessor's metrics changed and it is part of a soft-wrapped
// paragraph (has soft-wrap predecessors), the entire paragraph's earlier
// lines may be stale. Fall back to a full reformat to avoid leaving
// inconsistent metrics that crash on later hit-test/render (issue #11481).
if (!endOfParagraph && lineOffset != origEndOffset
&& lineIndex >= 2
&& _lineMetrics[lineIndex - 2].Length == _lineMetrics[lineIndex - 2].ContentLength)
{
_lineMetrics.Clear();
_viewportLineVisuals = null;
desiredSize = FullMeasureTick(constraintWidth, lineProperties);
return;
}
}
else
{
Expand Down