Skip to content

fixed(MultiSelect)清理分组状态下Divider重叠#8168

Merged
ArgoZhang merged 2 commits into
mainfrom
fixed-MultiSelect-ClearRepeatDivider
Jun 29, 2026
Merged

fixed(MultiSelect)清理分组状态下Divider重叠#8168
ArgoZhang merged 2 commits into
mainfrom
fixed-MultiSelect-ClearRepeatDivider

Conversation

@Tony-ST0754

@Tony-ST0754 Tony-ST0754 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

refactor:清理分组状态下生成多余的Divider组件信息

Link issues

fixes #8167

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Resolve overlapping dividers in MultiSelect when using grouped options by removing redundant group divider rendering.

Bug Fixes:

  • Prevent duplicate dividers from being rendered under grouped MultiSelect items, eliminating visual overlap.

Enhancements:

  • Simplify MultiSelect grouped rendering logic by removing unnecessary group footer divider output.

refactor:清理分组状态下生成多余的Divider组件信息
@bb-auto

bb-auto Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks for your PR, @Tony-ST0754. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto Bot added the bug Something isn't working label Jun 29, 2026
@bb-auto bb-auto Bot requested a review from ArgoZhang June 29, 2026 01:03
@bb-auto bb-auto Bot added this to the v10.7.0 milestone Jun 29, 2026
@sourcery-ai

sourcery-ai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes redundant group-level Divider rendering in MultiSelect’s grouped state to prevent overlapping dividers while keeping item row rendering intact.

Flow diagram for updated MultiSelect grouped rendering without Divider

flowchart TD
    A[RenderMultiSelectGrouped] --> B[For each itemGroup]
    B --> C[For each item in itemGroup]
    C --> D[RenderRow item]
    %% group-level Divider / GroupItemTemplate rendering removed in grouped state
Loading

File-Level Changes

Change Details Files
Stop rendering a Divider or GroupItemTemplate after each item group to eliminate duplicated separators in grouped MultiSelect dropdowns.
  • Removed the conditional block that rendered GroupItemTemplate or a Divider after iterating through each item group’s items
  • Left the item row rendering loop intact so grouped items still render correctly
src/BootstrapBlazor/Components/Select/MultiSelect.razor

Assessment against linked issues

Issue Objective Addressed Explanation
#8167 Fix the MultiSelect grouped mode so that Divider components do not overlap between consecutive groups (by removing redundant Divider rendering or otherwise spacing them correctly).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (68ff235) to head (8b4e0c5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8168      +/-   ##
==========================================
- Coverage   98.79%   98.79%   -0.01%     
==========================================
  Files         766      766              
  Lines       34230    34221       -9     
  Branches     4701     4699       -2     
==========================================
- Hits        33816    33807       -9     
  Partials      414      414              
Flag Coverage Δ
BB 98.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tony-ST0754 Tony-ST0754 changed the title fixed(MultiSelect)分组状态下Divider重叠 fixed(MultiSelect)清理分组状态下Divider重叠 Jun 29, 2026
@ArgoZhang ArgoZhang merged commit 676d9a1 into main Jun 29, 2026
5 checks passed
@ArgoZhang ArgoZhang deleted the fixed-MultiSelect-ClearRepeatDivider branch June 29, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(MultiSelect): 在分组模式下内部 Divider 组件重叠

2 participants