Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideTreeView APIs that operate on Items are now null-safe by guarding against Items being null before accessing or mutating them, preventing potential null reference exceptions when no Items collection is set. Sequence diagram for TreeView.SetActiveItem null-safe behaviorsequenceDiagram
participant Caller
participant TreeView
participant Items
Caller->>TreeView: SetActiveItem(item)
alt Items is not null
TreeView->>Items: GetAllItems()
Items-->>TreeView: IEnumerable<TreeViewItem<TItem>>
TreeView->>TreeView: SetActiveItem(val)
else Items is null
TreeView->>TreeView: [no-op]
end
Sequence diagram for TreeView.ClearCheckedItems null-safe behaviorsequenceDiagram
participant Caller
participant TreeView
participant Items
participant TreeNodeStateCache
Caller->>TreeView: ClearCheckedItems()
alt Items is not null
TreeView->>Items: ForEach(item)
loop each item and subitem
TreeView->>item: CheckedState = UnChecked
TreeView->>TreeNodeStateCache: ToggleCheck(item)
TreeView->>item: GetAllTreeSubItems()
TreeView->>TreeNodeStateCache: ToggleCheck(subitem)
end
TreeView->>TreeView: StateHasChanged()
else Items is null
TreeView->>TreeView: [no-op]
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![bb-auto[bot]](https://avatars.githubusercontent.com/in/287253?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In both SetActiveItem and ClearCheckedItems, consider using an early return when Items is null to reduce nesting and keep the methods’ main logic at the top level.
- Review whether ClearCheckedItems should still call StateHasChanged when Items is null, as the current guard prevents UI updates even if other state might have changed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In both SetActiveItem and ClearCheckedItems, consider using an early return when Items is null to reduce nesting and keep the methods’ main logic at the top level.
- Review whether ClearCheckedItems should still call StateHasChanged when Items is null, as the current guard prevents UI updates even if other state might have changed.
## Individual Comments
### Comment 1
<location path="src/BootstrapBlazor/Components/TreeView/TreeView.razor.cs" line_range="845-854" />
<code_context>
{
- item.CheckedState = CheckboxState.UnChecked;
- _treeNodeStateCache.ToggleCheck(item);
- item.GetAllTreeSubItems().ToList().ForEach(s =>
+ Items.ForEach(item =>
{
- s.CheckedState = CheckboxState.UnChecked;
- _treeNodeStateCache.ToggleCheck(s);
+ item.CheckedState = CheckboxState.UnChecked;
+ _treeNodeStateCache.ToggleCheck(item);
</code_context>
<issue_to_address>
**suggestion (performance):** Avoid the `ToList()` allocation and use `foreach` for sub-items iteration.
`item.GetAllTreeSubItems().ToList().ForEach(...)` creates an unnecessary list just to use `List<T>.ForEach`. Iterate directly over `GetAllTreeSubItems()` with `foreach` (e.g., `foreach (var s in item.GetAllTreeSubItems()) { ... }`) to avoid extra allocations and keep the code clearer.
```suggestion
Items.ForEach(item =>
{
item.CheckedState = CheckboxState.UnChecked;
_treeNodeStateCache.ToggleCheck(item);
foreach (var s in item.GetAllTreeSubItems())
{
s.CheckedState = CheckboxState.UnChecked;
_treeNodeStateCache.ToggleCheck(s);
}
});
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+845
to
854
| Items.ForEach(item => | ||
| { | ||
| s.CheckedState = CheckboxState.UnChecked; | ||
| _treeNodeStateCache.ToggleCheck(s); | ||
| item.CheckedState = CheckboxState.UnChecked; | ||
| _treeNodeStateCache.ToggleCheck(item); | ||
| item.GetAllTreeSubItems().ToList().ForEach(s => | ||
| { | ||
| s.CheckedState = CheckboxState.UnChecked; | ||
| _treeNodeStateCache.ToggleCheck(s); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
suggestion (performance): Avoid the ToList() allocation and use foreach for sub-items iteration.
item.GetAllTreeSubItems().ToList().ForEach(...) creates an unnecessary list just to use List<T>.ForEach. Iterate directly over GetAllTreeSubItems() with foreach (e.g., foreach (var s in item.GetAllTreeSubItems()) { ... }) to avoid extra allocations and keep the code clearer.
Suggested change
| Items.ForEach(item => | |
| { | |
| s.CheckedState = CheckboxState.UnChecked; | |
| _treeNodeStateCache.ToggleCheck(s); | |
| item.CheckedState = CheckboxState.UnChecked; | |
| _treeNodeStateCache.ToggleCheck(item); | |
| item.GetAllTreeSubItems().ToList().ForEach(s => | |
| { | |
| s.CheckedState = CheckboxState.UnChecked; | |
| _treeNodeStateCache.ToggleCheck(s); | |
| }); | |
| }); | |
| Items.ForEach(item => | |
| { | |
| item.CheckedState = CheckboxState.UnChecked; | |
| _treeNodeStateCache.ToggleCheck(item); | |
| foreach (var s in item.GetAllTreeSubItems()) | |
| { | |
| s.CheckedState = CheckboxState.UnChecked; | |
| _treeNodeStateCache.ToggleCheck(s); | |
| } | |
| }); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8170 +/- ##
==========================================
- Coverage 98.79% 98.79% -0.01%
==========================================
Files 766 766
Lines 34224 34230 +6
Branches 4699 4701 +2
==========================================
+ Hits 33811 33816 +5
- Partials 413 414 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8169
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add null-safety checks around TreeView Items usage to prevent errors when no items are set.
Bug Fixes: