Skip to content

[Fix]: Fixed an header parsing issue concerning authentication #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douxxtech merged 3 commits into from
Apr 30, 2026
Merged

[Fix]: Fixed an header parsing issue concerning authentication #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd49d30
made PARSE_AUTH_HEADER look for "auth" instead of "Auth"
douxxtech Apr 30, 2026
6a6aa90
Re-fixed PARSE_AUTH_HEADER
douxxtech Apr 30, 2026
f070478
updated the test program to check for auth
douxxtech Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/scripts/test-program.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,37 @@ else
fail "curl response did not contain expected content (got: $RESPONSE)"
fi

# Setup Auth in config
echo "AUTH_USER=admin" >> test-env.cfg
echo "AUTH_PASSWORD=password123" >> test-env.cfg
echo "AUTH_REALM=TestRealm" >> test-env.cfg

kill "$SERVER_PID" 2>/dev/null
./program -e test-env.cfg > /dev/null 2>&1 &
SERVER_PID=$!
sleep 1

# test 5
echo ">> Testing unauthorized access (expecting 401)..."
HTTP_STATUS=$(curl -s -o /dev/null -w "%{http_code}" localhost:8080)

if [ "$HTTP_STATUS" -eq 401 ]; then
pass "Correctly returned 401 Unauthorized"
else
fail "Expected 401, but got $HTTP_STATUS"
fi

# test 6
echo ">> Testing authorized access (expecting 200)..."
# Using -u for Basic Auth
HTTP_STATUS=$(curl -s -u admin:password123 -o /dev/null -w "%{http_code}" localhost:8080)

if [ "$HTTP_STATUS" -eq 200 ]; then
pass "Correctly returned 200 OK with valid credentials"
else
fail "Expected 200, but got $HTTP_STATUS"
fi

# summary
echo ""
echo "================================"
Expand Down
12 changes: 6 additions & 6 deletions macros/httputils.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,23 +366,23 @@ section .bss
xor r8, r8 ; offset

%%auth_scan:
; need at least 22 bytes left: "Authorization: Basic " (21) + 1 byte of token
; need at least 22 bytes left: "authorization: Basic " (21) + 1 byte of token
mov rax, r8
add rax, 22
cmp rax, %2
jg %%not_found

cmp byte [rsi + r8], 'A'
cmp byte [rsi + r8], 'a'
jne %%auth_next

; "Authorization: Basic " split into dwords:
; [+0] "Auth" = 0x68747541
; "authorization: Basic " split into dwords:
; [+0] "auth" = 0x68747561
; [+4] "oriz" = 0x7a69726f
; [+8] "atio" = 0x6f697461
; [+12] "n: B" = 0x42203a6e
; [+16] "asic" = 0x63697361
; [+20] " " = 0x20
cmp dword [rsi + r8 + 0], 0x68747541
; [+20] " " = 0x20
cmp dword [rsi + r8 + 0], 0x68747561
jne %%auth_next

cmp dword [rsi + r8 + 4], 0x7a69726f
Expand Down
Loading