You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure of the rational behind this change. null !== undefined.
Since null is a type in databases, and undefined isn't, I'm not sure what the ramifications of this are or what may break unexpectedly. If a property is null in the DB, I would like to know that it is. If it is missing from the object entirely this means a different thing all together.
This has come up before.
See here as well as a couple other pull requests.
I wanted to have only/omit query results be serialized without seeing all the columns i've omitted outputed with "null" value. That's the main reason, but as you already know, it could have side effects.
If you check the changes i had to make to the test suite, side effects are not that bad !
If a property is null in the db, and the property is queried, the ouput will be {'thatprop': null} as one expects, of course.
The only thing that could go wrong is
.find().only().each().save()
I suppose validation is going to kick out, when applicable.
But hey, if you do that, you get what you asked for.
kapouer
changed the title
Do not output properties when they are undefined
Do not output properties when they are undefined because they have been omitted from query
Dec 23, 2014
That title is a lot better and I get what you're after now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically this let us have for the same price
JSON.stringify(john) : {"height": 4}
instead of {"height": 4, "name": null}
Weirdly it wasn't easy to achieve.
This requires dresende/node-sql-query#37 for it to pass tests.
Mind that i tested only postgres (and sqlite ? i don't know) but kept in mind it should work everywhere.