Add OSC-8 hyperlink passthrough to plugin-view terminal pane - #960
Open
anutron wants to merge 1 commit into
Open
Add OSC-8 hyperlink passthrough to plugin-view terminal pane#960anutron wants to merge 1 commit into
anutron wants to merge 1 commit into
Conversation
The plugin-view cell-style mapper deliberately omitted the hyperlink path the default agent pane already had, so plugin-printed links (PR references, artifact links) rendered as plain text with no user-visible reason for the gap. Map cell.Link.URL to style.Url(...) the same way the default pane does; this package has no cache/desaturation layer to also update. Mouse-click passthrough stays out of scope (separate, larger UX work).
anutron
force-pushed
the
argus/plugin-link-passthrough
branch
from
August 30, 2026 18:33
1497bce to
f6ad879
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
2 tasks
anutron
added a commit
that referenced
this pull request
Sep 1, 2026
# Conflicts: # context/knowledge/index.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminalpane.uvCellToTcellStyle) deliberately omitted the OSC-8 hyperlink path the default agent pane's mapper (terminal.UvCellToTcellStyle) already has — the existing code comment said so outright.cell.Link.URL→style.Url(...)mapping so plugin-printed links (PR references, "view artifact" links) render as real clickable terminal hyperlinks, at parity with the default pane.cachedCell-equivalent replay cache and noDesaturateStyle-equivalent grayscale pass —paintcallsscreen.SetContentdirectly from the freshly mapped style every frame — so nothing else needed updating for the URL to survive redraws.OpenSpec
add-plugin-view-hyperlinks(proposal + delta spec underplugin-views+ tasks) created and archived in this same PR per repo policy — the base spec atopenspec/specs/plugin-views/spec.mdalready reflects the merged requirement.Docs
context/knowledge/gotchas/pty-terminal.mdand bumped the bullet count incontext/knowledge/index.md.Test plan
internal/tui/terminalpaneunit tests:TestUvCellToTcellStyle_Hyperlink(link maps to atcell.Stylewith the URL attached) andTestUvCellToTcellStyle_NoLinkLeavesUrlUnset(no-link regression guard).make build vet fmt-check lint-pr— clean.make test-cover-gate— full race suite green, 88.7% filtered coverage (floor 88);internal/tui/terminalpaneat 100%.openspec validate --all --strict— passes.make vuln— pre-existing stdlib-only findings (Go 1.26.3 vs 1.26.6), CI runs this step withcontinue-on-error: true; unrelated to this change.🤖 Generated with Claude Code