Fix reasoning manager response validation#377
Draft
RasulOs wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<request_accomplished>/<answer>tag and missing/invalidsuccessno longer defaults to true.FinalizeEvent(success=False)and makesuccess=Nonefinal answers fail closed.Tests
UV_CACHE_DIR=/private/tmp/uv-cache uv sync --python 3.13 --group dev --lockedUV_CACHE_DIR=/private/tmp/uv-cache uv run ruff check .UV_CACHE_DIR=/private/tmp/uv-cache uv run pytest -q->239 passedUV_CACHE_DIR=/private/tmp/uv-cache uv run python -m compileall -q mobilerun testsUV_CACHE_DIR=/private/tmp/uv-cache uv lock --checkUV_CACHE_DIR=/private/tmp/uv-cache uv run --with black black --check mobilerun/agent/manager/prompts.py mobilerun/agent/manager/manager_agent.py mobilerun/agent/manager/stateless_manager_agent.py mobilerun/agent/droid/droid_agent.py tests/test_manager_response_validation.pyLive regression
emulator-5554;mobilerun ping --device emulator-5554passed.401 Unauthorizedfromhttps://auth.openai.com/oauth/token. Classified as credential/login blocker, not code regression.5a4d2cd6-0ba6-49ac-bcdc-d4c709446017:devices --cloud,device ui --cloud,device screenshot --cloud, anddevice press home --cloud.Independent reviews
529 Overloadedretry. It found the implementation met the requirements and suggested extra tests for plan+empty/duplicate final tag salvage andrun_managerfailure wiring; those were added.