Refactor error handling in Request class to simplify error reporting#454
Open
jcarroll3 wants to merge 1 commit intodropbox:masterfrom
Open
Refactor error handling in Request class to simplify error reporting#454jcarroll3 wants to merge 1 commit intodropbox:masterfrom
jcarroll3 wants to merge 1 commit intodropbox:masterfrom
Conversation
|
|
jcarroll3
force-pushed
the
fix_uncessary_error_wrapping
branch
from
b27799f to
96c1b1f
Compare
jcarroll3
force-pushed
the
fix_uncessary_error_wrapping
branch
from
96c1b1f to
08f9500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkTaskFailure.failedWithError already carries a
ClientErrorvalue (defined at NetworkTask.swift:40). The old code passed this through.urlSessionError(error), which wraps theClientErrorinside anotherClientError.urlSessionErrorcase. This means consumers matching on the error (e.g.,.clientError(.fileAccessError(...))) would never match, the actual error was hidden behind an extra .urlSessionError layer.This change passes the
ClientErrordirectly toCallError(clientError:), preserving the original error kind (e.g.,.urlSessionError,.fileAccessError,.requestObjectDeallocated) so callers can match on it correctly.This is a bug. Error handling code downstream that pattern-matches on specific
ClientErrorcases will silently fail to match today because every failure-path error is uniformly reported as.urlSessionErrorregardless of its actual type.