Add --limit flag to ls and revs commands#305
Merged
Merged
Conversation
Cap results from ls with both server-side ListFolder limit and client-side pagination stop. Pass limit to ListRevisions for revs. Reject values exceeding uint32 max for ls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--limitflag tols— caps results with both server-sideListFolder.Limitand client-side pagination stop--limitflag torevs— passes limit toListRevisionsAPI (SDK default is 10 when unset)ls --limitvalues exceeding uint32 max (Dropbox API constraint)limitin JSON input for both commandsTest plan
go test ./cmd/...passesgolangci-lint runcleandbxcli ls --limit 5 /returns at most 5 entriesdbxcli ls --limit 5 --output=json /showsinput.limit: 5and at most 5 resultsdbxcli revs --limit 3 /file.txtreturns at most 3 revisionsdbxcli ls --limit 4294967296 /returns a validation error