Extract parseListOptions with validation and add --recursive flag#306
Merged
Conversation
Moves list option parsing into a shared module (list_options.go) that validates --sort, --time, and --time-format values before any API calls. Adds --recursive as the canonical flag for ls, keeping --recurse/-R as a backward-compatible alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmd/list_options.gowithparseListOptions()that validates--sort,--time, and--time-formatvalues before any API calls are made--recursiveas the canonical long flag forls, keeping--recurse/-Ras backward-compatible aliasesrevsandsearchcommands to use the new shared validatorTest plan
go test ./...passesgolangci-lint run ./...cleangofmt -s -l .clean--sort,--time,--time-formatvalues are rejected in ls, revs, and search--recursealias still sets recursive listing