Repository navigation
Fix experimental MessagePack round trips with current msgpack - #396
Merged
AndreyVMarkelov merged 1 commit intoOct 7, 2026
Merged
Conversation
|
Hi @Shubham-Padkonde, I’ve raised this with our engineering team for further review. They’ll be able to review the pull request and address it as appropriate. |
AndreyVMarkelov
self-requested a review
October 7, 2026 16:07
AndreyVMarkelov
approved these changes
Oct 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 49.98% 52.36% +2.37%
==========================================
Files 37 42 +5
Lines 8808 11451 +2643
Branches 1892 2393 +501
==========================================
+ Hits 4403 5996 +1593
- Misses 4087 4922 +835
- Partials 318 533 +215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessagePack round trips currently raise
TypeErrorwith msgpack 1.x because the encoder and decoder still pass the removedencodingargument. This updates the experimental serializer to use binary-aware encoding and decoding, while preserving arbitrary bytes written using the legacy raw representation.The decoder now also forwards
alias_validatorsandstrictby name: positional forwarding was binding them to the wrong arguments aftercaller_permissionswas added. MessagePack is included in the test dependencies so this path is exercised.Validation: all 198 tests pass on Linux with msgpack 1.2.3. Nine new regression cases failed before the fix and pass afterward, covering Unicode, binary collections, legacy raw bytes, alias validation, and strict decoding. Flake8 passes for the changed Python files. Two existing tests encounter Windows-specific filesystem/whitespace failures; the complete Linux run passes.