Skip to content

Fix: NotAllowedResponse accepts an arbitrary unvalidated status_code despite being the 405 response #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pullapprove5 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: NotAllowedResponse accepts an arbitrary unvalidated status_code despite being the 405 response #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions plain/plain/http/response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,10 @@ def __init__(


class NotAllowedResponse(Response):
"""HTTP 405 response"""
"""HTTP 405 response.

The constructor is pinned: no status_code parameter, so this class
always means exactly "405 method not allowed"."""

status_code = 405

Expand All @@ -807,14 +810,12 @@ def __init__(
permitted_methods: list[str],
*,
content_type: str | None = None,
status_code: int | None = None,
reason: str | None = None,
charset: str | None = None,
headers: dict[str, Any] | None = None,
):
super().__init__(
content_type=content_type,
status_code=status_code,
reason=reason,
charset=charset,
headers=headers,
Expand Down
8 changes: 8 additions & 0 deletions plain/tests/public/test_http_bodiless_responses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
FileResponse,
HTTPException,
JsonResponse,
NotAllowedResponse,
NotModifiedResponse,
Response,
StreamingResponse,
Expand Down Expand Up @@ -158,6 +159,13 @@ def test_not_modified_response_signature_is_pinned():
NotModifiedResponse(status_code=200) # ty: ignore[unknown-argument]


def test_not_allowed_response_signature_is_pinned():
# No status_code parameter — this class always means exactly "405
# method not allowed".
with pytest.raises(TypeError):
NotAllowedResponse(["GET"], status_code=200) # ty: ignore[unknown-argument]


def test_setting_content_after_bodiless_status_raises():
response = Response(status_code=204)
with pytest.raises(ValueError, match="cannot have a body"):
Expand Down
Loading