Repository navigation
Conversation
JustMaris
reviewed
Oct 13, 2026
JustMaris
left a comment
Member
There was a problem hiding this comment.
Thanks for this. The mismatch between the status cards and the action list was a real bug, and the regression tests are thorough. Not merging for now. Requests before it can go in:
- Name.
no_datareads like "data missing". It lands in the export JSON (response_type,pipeline_status), and docs/stability.md makes export values add-only in 1.x, so we can't rename it later without 2.0. Could we useno_data_held, matching the "No data held" label? Please also keep it separate fromsuccess/confirmedin the evidence export. - Title/scope. This adds a category, search and a data migration, so the squash title should be
feat(pipeline): ..., notfix. If it's easy, splitting the classifier and migration from the counts/filters/search UI would make both easier to review. - Migration.
MigrateNoDataopens a write transaction and inserts intodata_migrationson everyopenHistoryStore, so eveneraser statustakes the writer lock. Please do a read-onlySELECTfor the marker first and only take the write path when it's missing. - Auto-resolve. The migration also sets requests to the new status and completes pending tasks from a regex verdict, which is hard to undo. Can it only reclassify (and leave resolution to the existing reclassify action), or at least be limited to
confidence >= 0.7 && !needs_reviewwith a test for the multilingual/conditional cases? - Classifier.
subjectRejectionPatternslostnot found,no recordandunable to locate|find. That's intended, but please note in docs/broker-replies.md how "no data" replies should now be triaged. - Nits. Redundant
if z.Err() == io.EOF { break }; breakinresponsePreview;lowered[:at]is a byte offset into the lowercased string and can drift fromrunesfor some Unicode.
CI is gated on maintainer approval and will run once these changes are pushed.
This was referenced Oct 13, 2026
Member
|
Superseded by #165, which carries these commits forward with the review asks applied. Thanks for the work on this, Magnus. |
JustMaris
added a commit
that referenced
this pull request
Oct 17, 2026
Picks up magnus188's #158 and applies the 2026-10-13 review asks: no_data_held rename, read-only migration marker, reclassify-only migration, responsePreview nits, triage docs, and direct tests for the pipeline queries and no-data resolution. Commits keep magnus188's authorship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes inconsistencies in the Pipeline page and makes it easier to find and act on broker responses.
I created it after seeing 18 pending tasks in the status cards while the Action Required section said “No pending tasks.” Changing the response-type dropdown also did not update the list. When a broker replied that it had no records of me, there was no search to help find the message or a clear category to distinguish that outcome from a rejected request.
The changes address those problems together:
no_dataclassification. This means the broker reports having no matching data; it does not imply that data was deleted. Conditional statements, conflicting replies, and requests for verification remain flagged for review. The category is reflected in the web UI, CLI summaries, and evidence export.Existing saved replies benefit from the classification fix too. On the first history open after upgrading, a versioned transaction reclassifies qualifying stored messages without fetching mail. A confident latest reply can resolve the current request and superseded pending work, while newer requests, replies, and tasks are preserved. The upgrade also preserves completed/skipped work, manual pipeline progress, original messages, and existing task notes. It is safe to retry after a rollback and runs only once per database.
Most of the small changes across CLI commands route history opening through that shared upgrade helper, so the fix applies whether someone starts the web UI or uses the CLI. Existing export JSON field names are unchanged. The documentation explains the new category and Pipeline behavior.
Validation completed locally:
go test ./...,go test -race ./...,go vet ./..., build, andgolangci-lint run ./...(v2.14.0, zero issues) passed. Both embedded broker lists also passed validation.