Skip to content

fix(audit): keep broker lists canonical and report dead-end entries - #162

Merged
JustMaris merged 3 commits into
mainfrom
fix/audit-canonical-format
Oct 13, 2026
Merged

JustMaris merged 3 commits into
mainfrom
fix/audit-canonical-format

Conversation

@JustMaris

Copy link
Copy Markdown
Member

Fixes #160.

  • Remove brigthswipe: email domain is NXDOMAIN, website is the same dead domain, no opt-out URL. 724 -> 723 brokers.
  • TestEmbeddedListsCanonical fails when data/brokers.yaml or data/brokers-verified.yaml differs from yaml.Marshal output, so weekly audit PRs only contain real changes. -update rewrites them. brokers-verified.yaml was normalized (format only; same 60 entries).
  • audit-brokers now reports entries with a dead email, unreachable website and no opt_out_url under "No working channel left". Informational; --fix still only clears emails.
  • docs/auditing.md updated.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@JustMaris
JustMaris enabled auto-merge (squash) October 13, 2026 04:35
@JustMaris
JustMaris merged commit 0979eb6 into main Oct 13, 2026
6 checks passed
@JustMaris
JustMaris deleted the fix/audit-canonical-format branch October 13, 2026 04:36
@dnb-robot dnb-robot Bot mentioned this pull request Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit-brokers --fix: reformats whole brokers.yaml; leaves brigthswipe with no working contact

2 participants