refactor: simplify primary key check logic (no functional changes) #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify array and single value handling in is_column_primary_key? using Array() wrapper. Reduces nested conditionals from 15 to 3 lines while maintaining identical behavior. Pure refactoring with zero feature changes.
OdenTakashi
force-pushed
the
refactor/simplify-primary-key-check
branch
from
633e685 to
bc1e1b4
Compare
drwl
approved these changes
Feb 10, 2026
Owner
drwl
left a comment
drwl
left a comment
There was a problem hiding this comment.
Seems right to me, thanks for simplifying this crazy conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you always for your maintenance.
Unify array and single value handling in is_column_primary_key? using Array() wrapper.
Reduces nested conditionals from 15 to 3 lines while maintaining identical behavior.
Pure refactoring with zero feature changes.