Skip to content

Conversation

@bensheldon
Copy link

@bensheldon bensheldon commented Oct 25, 2025

Fixes #286

This PR recreates the Active Record logic for fetching the columns from the schema cache before they are filter based on Active Record's ignored_columns/only_columns configuration.

@drwl
Copy link
Owner

drwl commented Feb 10, 2026

Hi @bensheldon apologies on the months long delay in response -- the issue was helpful in providing context. I do think that this could cause regressions for other users of this gem because adding this in its current state would mean ignored columns will appear in annotations.

Can this new behavior be gated behind an option flag with the default preserving the existing behavior?

@bensheldon
Copy link
Author

Can this new behavior be gated behind an option flag with the default preserving the existing behavior?

Yep, let me give that a shot.

@bensheldon bensheldon force-pushed the patch-1 branch 2 times, most recently from 5c99d11 to fd3e571 Compare February 11, 2026 00:44
@bensheldon
Copy link
Author

@drwl ok, ready to go. I'd love your feedback on the configuration value naming. load_columns_from_schema is how it works, I dunno if something declarative like include_active_record_ignored_columns would be better?

Also, I wasn't able to run all the test matrix locally so I'm not sure if I needed to change all the TestDefault model files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix missing annotation for Active Record ignored columns

2 participants