Repository navigation
feat(mypy): infer Exception error type for unit methods on *E aliases (#407) - #2567
Closed
hamid-digitalmarketer wants to merge 3 commits into
Closed
hamid-digitalmarketer wants to merge 3 commits into
hamid-digitalmarketer wants to merge 3 commits into
Conversation
Contributor
Merging this PR will not alter performance1 note
Comparing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #407
Problem
When calling unit methods on container aliases that fix their error type to
Exception(e.g.IOResultE.from_value(1),ResultE.from_value(1),FutureResultE.from_value(1)),mypypreviously typed the return value asContainer[ValueType, Any]rather thanContainer[ValueType, Exception], because the generic unit constructor cannot infer the unprovided error type parameter and defaults toAny.Solution
returns.contrib.mypy._features.alias_e.analyzemethod hook for unit constructor methods across all*Ealiases (ResultE,IOResultE,FutureResultE,RequiresContextResultE,RequiresContextIOResultE,RequiresContextFutureResultE).*Ealias whose bound type fixes the error type tobuiltins.Exception, anyAnyTypein that position is rewritten tobuiltins.Exception.IOResult.from_value(1)) are unaffected and retain their defaultAnyerror type.Verification
typesafety/test_io/test_ioresult_container/test_ioresult_typecast.yml.*Econtainers:Contributor Direct Contact
For direct communication regarding this contribution, technical questions, collaboration, or follow-up:
Direct Contact / WhatsApp: +923167417135
Please feel free to contact me directly to discuss the implementation or coordinate further improvements.