Skip to content

Conversation

@JonasRied
Copy link
Contributor

@JonasRied JonasRied commented Nov 6, 2023

Pull Request (PR) description

Adds the parameter 'IsSingleInstance' as suggested in #42.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #65 (24b9088) into master (7358992) will increase coverage by 0%.
The diff coverage is 98%.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #65   +/-   ##
====================================
  Coverage      80%   80%           
====================================
  Files           6     6           
  Lines         759   766    +7     
====================================
+ Hits          613   620    +7     
  Misses        146   146           
Files Coverage Δ
...eOnlineServerFarm/MSFT_OfficeOnlineServerFarm.psm1 95% <98%> (+<1%) ⬆️

@johlju johlju added the needs review The pull request needs a code review. label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review The pull request needs a code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OfficeOnlineServerFarm: InternalURL should not be mandatory

2 participants