Repository navigation
Bound SSHTunnel control commands with timeouts and BatchMode - #4354
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4349
SSHTunnel.check(),close(),acheck(),aclose()andaexec()now time out afterSSH_TIMEOUTand kill thesshprocess, so a hung control command can no longer block instance processing;aexec()takes atimeoutparameter, and gateway updates are bounded at 600s.-F none -o BatchMode=yesand stdin from/dev/null, so if the master breaks off the initial exchange and OpenSSH falls back to a direct connection (which OpenSSH does!), it fails instead of prompting on the server's terminal or picking up the user's ssh config.aclose()now logs the command output instead of the stream object.