Repository navigation
Replace freezegun with time-machine - #4360
Merged
Merged
Conversation
freezegun swaps datetime.datetime for FakeDatetime, which pydantic 2.14 can't build schemas for (#4357).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4357. freezegun replaces
datetime.datetimewithFakeDatetimewhile frozen, which pydantic 2.14 can't build schemas for. time-machine patches the clock functions at the C level and keeps the realdatetimeclass.freeze_time(X)withtime_machine.travel(X, tick=False), and class-level@freeze_timewith the@pytest.mark.time_machinemarker.get_current_datetime()instead of naivedatetime.now()for gatewayChatModel.created_at, so the registry test doesn't depend on the local timezone.FakeDatetimeroute schema warm-up from the server testsconftest.py.