Update KakyomuParser to handle new TOC Updates #2629
Update KakyomuParser to handle new TOC Updates #2629dteviot merged 1 commit intodteviot:ExperimentalTabModefrom
Conversation
There was a problem hiding this comment.
Is this fixed? I still get an error when I try
There was a problem hiding this comment.
PR isn't get approved yet. my update version is working now
There was a problem hiding this comment.
PR isn't get approved yet. my update version is working now
how do you update your version of the code? do you run it without an extension?
There was a problem hiding this comment.
build the extention using my fork
There was a problem hiding this comment.
I successfully downloaded all chapters from a kakuyomu link, using your version. However the download prompt is not appearing. When i click error in extension page, it shows....
Uncaught (in promise) ReferenceError: DOMPurify is not defined
any idea?
There was a problem hiding this comment.
Once the process is 100% complete, there's usually an option to save the EPUB file. This one doesn't appear, and instead, there's an error in the DOM.
There was a problem hiding this comment.
weird...are you sure you build it correctly? clone my project -> npm install -> npm run init
i try reinstall since start it works well.
There was a problem hiding this comment.
okay, thanks, I followed your project and it worked, for the official one, even though the owner said it had been merged, it still had the same error with the table of contents.
There was a problem hiding this comment.
That's strange, I downloaded the latest developer extension, and was able to download 3 kakuyomu novels without issue
There was a problem hiding this comment.
I don't know, maybe I'll try again later.
|
@lemonatez Thank you for the contribution.
As @lemonatez says, that means you have not loaded the dependencies. In this case DOMPurify That said, fix has been merged so... Test versions for Firefox and Chrome have been uploaded to https://github.com/dteviot/WebToEpub/releases/tag/developer-build. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-installation and let us know how it goes. |
4 participants
Fix #2611