Repository navigation
Honor Blob ranges and independent read cursors - #911
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
Member
|
Hi, thanks for the PR! I need to do some more checks here - will follow-up a bit later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a bounded Blob stream currently returns the whole value, and advancing a stream or calling getBytes changes the cursor used by other reads. The fix duplicates the ByteBuffer for each read, bounds streams by the JDBC one-based position and requested length, and clips getBytes to the remaining bytes. Invalid ranges raise SQLException before integer conversion.
Validation on macOS arm64: compiled all Java production and test sources against the existing JNI artifact; ran test_blob (7 tests). New regressions fail against the original Java implementation and pass with this patch. The full official clang-format 11 check passes. Full native and multi-platform CI remain to be run.
AI assistance was used for implementation and source review.