Repository navigation
Return false when array result cursors move out of bounds - #912
Merged
staticlibs merged 1 commit intoOct 10, 2026
Merged
staticlibs merged 1 commit into
staticlibs merged 1 commit into
Conversation
Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
staticlibs
approved these changes
Oct 10, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! Looks good to me.
staticlibs
pushed a commit
that referenced
this pull request
Oct 10, 2026
This is a backport of the PR #912 to `v2.0-cyanoptera` branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array-backed ResultSet navigation currently reports success at before-first and after-last sentinels, including on empty arrays. The fix returns false outside actual rows, reports getRow() as zero off a row, and keeps empty-result position predicates false. Regression coverage exercises absolute, relative, next and previous navigation and verifies element values.
Validation on macOS arm64: compiled all Java production and test sources against the existing JNI artifact; ran test_array (2 tests). New regressions fail against the original Java implementation and pass with this patch. The full official clang-format 11 check passes. Full native and multi-platform CI remain to be run.
AI assistance was used for implementation and source review.